Add workers.celery.podAnnotations & workers.kubernetes.podAnnotations#65027
Merged
jscheffl merged 4 commits intoapache:mainfrom Apr 11, 2026
Merged
Conversation
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR introduces new Helm values for worker pod annotations split by worker type (workers.celery.podAnnotations and workers.kubernetes.podAnnotations) and deprecates the legacy workers.podAnnotations.
Changes:
- Add
workers.celery.podAnnotationsandworkers.kubernetes.podAnnotationstovalues.yamlandvalues.schema.json, and markworkers.podAnnotationsas deprecated. - Update pod-template-file annotation merging to prefer
workers.kubernetes.podAnnotations(with fallback to the deprecated key). - Update/add Helm chart tests to validate templating, precedence, and per-worker annotation behavior; add deprecation note and newsfragment.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| helm-tests/tests/helm_tests/airflow_core/test_worker_sets.py | Adds coverage for Celery worker set podAnnotations overrides. |
| helm-tests/tests/helm_tests/airflow_core/test_worker.py | Adjusts worker annotation tests to use workers.celery.podAnnotations. |
| helm-tests/tests/helm_tests/airflow_aux/test_pod_template_file.py | Expands tests around templating / precedence of global vs worker annotation sources. |
| helm-tests/tests/helm_tests/airflow_aux/test_annotations.py | Updates annotation templating tests; adds Celery-specific workers annotation cases and removes redundant pod-template-file tests. |
| chart/values.yaml | Deprecates workers.podAnnotations; adds workers.celery.podAnnotations and workers.kubernetes.podAnnotations. |
| chart/values.schema.json | Updates schema descriptions and adds schema entries for the new fields. |
| chart/templates/NOTES.txt | Adds a deprecation warning for workers.podAnnotations. |
| chart/newsfragments/65027.significant.rst | Documents the deprecation and migration path. |
| chart/files/pod-template-file.kubernetes-helm-yaml | Switches pod-template-file annotation source to workers.kubernetes.podAnnotations with fallback. |
helm-tests/tests/helm_tests/airflow_aux/test_pod_template_file.py
Outdated
Show resolved
Hide resolved
helm-tests/tests/helm_tests/airflow_aux/test_pod_template_file.py
Outdated
Show resolved
Hide resolved
helm-tests/tests/helm_tests/airflow_aux/test_pod_template_file.py
Outdated
Show resolved
Hide resolved
helm-tests/tests/helm_tests/airflow_aux/test_pod_template_file.py
Outdated
Show resolved
Hide resolved
helm-tests/tests/helm_tests/airflow_aux/test_pod_template_file.py
Outdated
Show resolved
Hide resolved
Miretpl
force-pushed
the
add-workers-celery-k8s-pod-annotations
branch
from
f8db0a1 to
5d6e9bb
Compare
Miretpl
force-pushed
the
add-workers-celery-k8s-pod-annotations
branch
from
5d6e9bb to
b2f051a
Compare
Miretpl
requested review from
bugraoz93,
dstandish,
hussein-awala,
jedcunningham and
jscheffl
as code owners
jscheffl
approved these changes
Apr 11, 2026
jscheffl
added
the
backport-to-chart/v1-2x-test
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2026
…etes.podAnnotations (#65027) * Move pod_template annotations tests & add missing test cases * Add workers.celery.podAnnotations & workers.kubernetes.podAnnotations * Add newsfragment * Make pod template tests more robust (cherry picked from commit 8a02c43) Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
Backport successfully created: chart/v1-2x-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
jscheffl
pushed a commit
that referenced
this pull request
Apr 11, 2026
…etes.podAnnotations (#65027) (#65068) * Move pod_template annotations tests & add missing test cases * Add workers.celery.podAnnotations & workers.kubernetes.podAnnotations * Add newsfragment * Make pod template tests more robust (cherry picked from commit 8a02c43) Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #28880
This PR introduces two new fields:
workers.celery.podAnnotationsandworkers.kubernetes.podAnnotations. Theworkers.podAnnotationsfield is now deprecated.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.