UI: Fix log line number gaps caused by group markers#65039
Merged
bbovenzi merged 2 commits intoapache:mainfrom Apr 13, 2026
Merged
UI: Fix log line number gaps caused by group markers#65039bbovenzi merged 2 commits intoapache:mainfrom
bbovenzi merged 2 commits intoapache:mainfrom
Conversation
dandanseo123
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
eladkal
added
type:bug-fix
dandanseo123
force-pushed
the
fix/log-ui-line-number-irregularities
branch
2 times, most recently
from
5124744 to
0916e22
Compare
bbovenzi
approved these changes
Apr 13, 2026
Contributor
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
Nice work. Just two nits.
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx
Outdated
Show resolved
Hide resolved
dandanseo123
force-pushed
the
fix/log-ui-line-number-irregularities
branch
from
0916e22 to
1a294e6
Compare
Contributor
Author
|
@bbovenzi addressed PR comments! |
dandanseo123
force-pushed
the
fix/log-ui-line-number-irregularities
branch
from
1a294e6 to
e630126
Compare
Contributor
|
Thanks! Looks like we just need to fix one react test |
dandanseo123
requested review from
amoghrajesh,
ashb,
bugraoz93,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
kaxil,
potiuk,
shahar1 and
vincbeck
as code owners
added 2 commits
April 13, 2026 16:10
Group markers (::group:: / ::endgroup::) consumed line number indices but were removed during group processing, leaving gaps in the displayed line numbers (e.g. 0, 2, 3 instead of 0, 1, 2). Pre-scan the log data to assign sequential display line numbers that skip group markers, and pin wrapped line numbers to the top with alignItems flex-start.
dandanseo123
force-pushed
the
fix/log-ui-line-number-irregularities
branch
from
a91ab46 to
b191fe4
Compare
Contributor
Author
|
@bbovenzi fixed |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2026
) * Fix log line number gaps caused by group markers (#47888) Group markers (::group:: / ::endgroup::) consumed line number indices but were removed during group processing, leaving gaps in the displayed line numbers (e.g. 0, 2, 3 instead of 0, 1, 2). Pre-scan the log data to assign sequential display line numbers that skip group markers, and pin wrapped line numbers to the top with alignItems flex-start. * fix test --------- (cherry picked from commit 55162a3) Co-authored-by: Daniel Seo <dseo1004@gmail.com> Co-authored-by: hseo36 <hseo36@bloomberg.net>
Backport successfully created: v3-2-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 13, 2026
…che#65039) * Fix log line number gaps caused by group markers (apache#47888) Group markers (::group:: / ::endgroup::) consumed line number indices but were removed during group processing, leaving gaps in the displayed line numbers (e.g. 0, 2, 3 instead of 0, 1, 2). Pre-scan the log data to assign sequential display line numbers that skip group markers, and pin wrapped line numbers to the top with alignItems flex-start. * fix test --------- (cherry picked from commit 55162a3) Co-authored-by: Daniel Seo <dseo1004@gmail.com> Co-authored-by: hseo36 <hseo36@bloomberg.net>
This was referenced Apr 14, 2026
github-actions bot
pushed a commit
to baraka-akeyless/airflow
that referenced
this pull request
Apr 14, 2026
…che#65039) * Fix log line number gaps caused by group markers (apache#47888) Group markers (::group:: / ::endgroup::) consumed line number indices but were removed during group processing, leaving gaps in the displayed line numbers (e.g. 0, 2, 3 instead of 0, 1, 2). Pre-scan the log data to assign sequential display line numbers that skip group markers, and pin wrapped line numbers to the top with alignItems flex-start. * fix test --------- (cherry picked from commit 55162a3) Co-authored-by: Daniel Seo <dseo1004@gmail.com> Co-authored-by: hseo36 <hseo36@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Group markers (
::group::/::endgroup::) consumed line number indices but were removed during group processing, leaving gaps in the displayed line numbers (e.g. 0, 2, 3 instead of 0, 1, 2). Also fixed line number alignment on wrapped log lines.alignItems: flex-startcloses: #47888
Screenshot
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code following the guidelines