Skip to content

[v3-2-test] Fix backport test for log line number gap fix (#65039)#65187

Merged
pierrejeambrun merged 2 commits intoapache:v3-2-testfrom
dandanseo123:fix/backport-65039-v3-2-test
Apr 14, 2026
Merged

[v3-2-test] Fix backport test for log line number gap fix (#65039)#65187
pierrejeambrun merged 2 commits intoapache:v3-2-testfrom
dandanseo123:fix/backport-65039-v3-2-test

Conversation

@dandanseo123
Copy link
Copy Markdown
Contributor

The auto-backport PR #65183 fails CI because the test was written against main's new log architecture (#63467, which doesn't exist on v3-2-test.

Only the test needed adapting.

Supersedes: #65183
closes: #47888
related: #65039


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code

Generated-by: Claude Code following the guidelines

…che#65039)

* Fix log line number gaps caused by group markers (apache#47888)

Group markers (::group:: / ::endgroup::) consumed line number indices
but were removed during group processing, leaving gaps in the displayed
line numbers (e.g. 0, 2, 3 instead of 0, 1, 2).

Pre-scan the log data to assign sequential display line numbers that
skip group markers, and pin wrapped line numbers to the top with
alignItems flex-start.

* fix test

---------
(cherry picked from commit 55162a3)

Co-authored-by: Daniel Seo <dseo1004@gmail.com>
Co-authored-by: hseo36 <hseo36@bloomberg.net>
@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Apr 14, 2026
The cherry-picked test from main used the new flat ParsedLogEntry
group rendering (apache#63467) which doesn't exist on v3-2-test. Rewrite
to query line number anchors directly from the DOM.
@dandanseo123 dandanseo123 force-pushed the fix/backport-65039-v3-2-test branch from d732578 to 341770e Compare April 14, 2026 01:48
@pierrejeambrun pierrejeambrun changed the title Fix backport test for log line number gap fix (#65039) [v3-2-test] Fix backport test for log line number gap fix (#65039) Apr 14, 2026
Copy link
Copy Markdown
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, unrelated CI failure, merging

@pierrejeambrun pierrejeambrun merged commit bd4d5de into apache:v3-2-test Apr 14, 2026
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants