Skip to content

[AIRFLOW-5887] User is removed from CI images.#6540

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:remove-airflow-user
Nov 12, 2019
Merged

[AIRFLOW-5887] User is removed from CI images.#6540
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:remove-airflow-user

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Nov 10, 2019

The AIRFLOW_USER is not needed any more in CI images. It will be needed in Prod
images but it will be implemented differently there.

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5887
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@potiuk potiuk force-pushed the remove-airflow-user branch 2 times, most recently from bf97618 to 64c4e98 Compare November 10, 2019 22:35
@codecov-io
Copy link

codecov-io commented Nov 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f2473b3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6540   +/-   ##
=========================================
  Coverage          ?   83.78%           
=========================================
  Files             ?      638           
  Lines             ?    36858           
  Branches          ?        0           
=========================================
  Hits              ?    30882           
  Misses            ?     5976           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2473b3...1718070. Read the comment docs.

@potiuk potiuk added prod-image area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code labels Nov 11, 2019
@potiuk potiuk force-pushed the remove-airflow-user branch 2 times, most recently from adcd864 to 548f63c Compare November 12, 2019 13:22
The AIRFLOW_USER is not needed any more in CI images. It will be needed in Prod
images but it will be implemented differently there.
@potiuk potiuk force-pushed the remove-airflow-user branch from 548f63c to 1718070 Compare November 12, 2019 15:31
@potiuk potiuk changed the title [AIRFLOW-5887] User is removed from CI images. Depends on [AIRFLOW-5886] [AIRFLOW-5887] User is removed from CI images. Nov 12, 2019
@potiuk potiuk merged commit 75a43cc into apache:master Nov 12, 2019
potiuk added a commit that referenced this pull request Nov 12, 2019
The AIRFLOW_USER is not needed any more in CI images. It will be needed in Prod
images but it will be implemented differently there.

(cherry picked from commit 75a43cc)
GnunuX pushed a commit to GnunuX/airflow that referenced this pull request Nov 13, 2019
The AIRFLOW_USER is not needed any more in CI images. It will be needed in Prod
images but it will be implemented differently there.
eladkal pushed a commit to eladkal/airflow that referenced this pull request Dec 2, 2019
The AIRFLOW_USER is not needed any more in CI images. It will be needed in Prod
images but it will be implemented differently there.

(cherry picked from commit 75a43cc)
kaxil pushed a commit that referenced this pull request Dec 12, 2019
The AIRFLOW_USER is not needed any more in CI images. It will be needed in Prod
images but it will be implemented differently there.

(cherry picked from commit 75a43cc)
@potiuk potiuk added the area:production-image Production image improvements and fixes label Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code area:production-image Production image improvements and fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants