Fix Alibaba OSS provider: configurable endpoint and task handler log …#66479
Open
hasangzc wants to merge 1 commit intoapache:mainfrom
Open
Fix Alibaba OSS provider: configurable endpoint and task handler log …#66479hasangzc wants to merge 1 commit intoapache:mainfrom
hasangzc wants to merge 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
5d88022 to
2b11c34
Compare
…reading Co-authored-by: Cursor <cursoragent@cursor.com>
2b11c34 to
6d43b41
Compare
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OSSHook._get_client(): The endpoint was hardcoded to the public URL
(
oss-{region}.aliyuncs.com), making it impossible to use VPC/internalendpoints (e.g.
oss-eu-central-1-internal.aliyuncs.com). Now reads fromthe connection's
extraconfig withendpointkey, falling back to thepublic default.
OSSTaskHandler._read(): Called
self.oss_log_exists()andself.oss_read()which don't exist on
OSSTaskHandler. These methods live onOSSRemoteLogIOand must be accessed via
self.io. This caused the webserver to fail silentlywhen reading logs from OSS.
Test plan
test_get_client_uses_default_endpoint- verifies default endpoint behaviortest_get_client_uses_custom_endpoint_from_connection- verifies custom endpoint from extra configtest_read_calls_oss_methods_via_io- verifies _read() uses self.iotest_read_falls_back_to_local_when_no_remote_log- verifies local fallbackWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.