fix(alibaba): call self.io.oss_log_exists in OSSTaskHandler._read#66522
Closed
wenbinye wants to merge 1 commit intoapache:mainfrom
Closed
fix(alibaba): call self.io.oss_log_exists in OSSTaskHandler._read#66522wenbinye wants to merge 1 commit intoapache:mainfrom
wenbinye wants to merge 1 commit intoapache:mainfrom
Conversation
…TaskHandler._read OSSTaskHandler._read() was calling self.oss_log_exists() and self.oss_read(), but these methods are only defined in OSSRemoteLogIO, not in OSSTaskHandler. Fix by calling self.io.oss_log_exists() and self.io.oss_read() directly on the OSSRemoteLogIO instance. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hi, this fix is already covered in #66479 which was opened 2 days earlier. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OSSTaskHandler._read() calls self.oss_log_exists() and self.oss_read(), but these methods are only defined in OSSRemoteLogIO, not in OSSTaskHandler itself. This causes AttributeError when the Airflow UI reads task logs from OSS after task completion.
Fix: change the calls in _read() to use self.io.oss_log_exists() and self.io.oss_read() directly.
🤖 Generated with Claude Code