Stop passing project_id to the Pinecone client constructor#66601
Merged
potiuk merged 1 commit intoapache:mainfrom May 8, 2026
Merged
Stop passing project_id to the Pinecone client constructor#66601potiuk merged 1 commit intoapache:mainfrom
project_id to the Pinecone client constructor#66601potiuk merged 1 commit intoapache:mainfrom
Conversation
The Pinecone Python SDK we depend on (`pinecone>=7.0.0`) removed `project_id` from the `Pinecone()` constructor — passing it, even as `None`, now raises `TypeError: Pinecone() got unexpected keyword arguments: ['project_id']` from the SDK's strict-kwargs validation. That broke `PineconeHook.pinecone_client` and the two unit tests that exercise it (`test_upsert`, `test_debug_curl_setting`) on the `Compat 3.0.6:P3.10` provider matrix. Drop the `project_id` argument from the `Pinecone(...)` call, plus the local extras lookup that fed it. Also remove the corresponding `project_id` connection-form widget and `provider.yaml` extra so newly created Pinecone connections don't show a field that has no effect. Existing connections that already have `project_id` saved in their extras JSON keep the value on disk; it is silently ignored, which matches what the SDK does anyway.
1 task
jscheffl
approved these changes
May 8, 2026
jscheffl
reviewed
May 8, 2026
Contributor
There was a problem hiding this comment.
Should this add some note of deprecation into changelog.rst?
arpitrathore
pushed a commit
to arpitrathore/airflow
that referenced
this pull request
May 9, 2026
…66601) The Pinecone Python SDK we depend on (`pinecone>=7.0.0`) removed `project_id` from the `Pinecone()` constructor — passing it, even as `None`, now raises `TypeError: Pinecone() got unexpected keyword arguments: ['project_id']` from the SDK's strict-kwargs validation. That broke `PineconeHook.pinecone_client` and the two unit tests that exercise it (`test_upsert`, `test_debug_curl_setting`) on the `Compat 3.0.6:P3.10` provider matrix. Drop the `project_id` argument from the `Pinecone(...)` call, plus the local extras lookup that fed it. Also remove the corresponding `project_id` connection-form widget and `provider.yaml` extra so newly created Pinecone connections don't show a field that has no effect. Existing connections that already have `project_id` saved in their extras JSON keep the value on disk; it is silently ignored, which matches what the SDK does anyway.
jason810496
pushed a commit
to jason810496/airflow
that referenced
this pull request
May 11, 2026
…66601) The Pinecone Python SDK we depend on (`pinecone>=7.0.0`) removed `project_id` from the `Pinecone()` constructor — passing it, even as `None`, now raises `TypeError: Pinecone() got unexpected keyword arguments: ['project_id']` from the SDK's strict-kwargs validation. That broke `PineconeHook.pinecone_client` and the two unit tests that exercise it (`test_upsert`, `test_debug_curl_setting`) on the `Compat 3.0.6:P3.10` provider matrix. Drop the `project_id` argument from the `Pinecone(...)` call, plus the local extras lookup that fed it. Also remove the corresponding `project_id` connection-form widget and `provider.yaml` extra so newly created Pinecone connections don't show a field that has no effect. Existing connections that already have `project_id` saved in their extras JSON keep the value on disk; it is silently ignored, which matches what the SDK does anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provider's compat job
(
Compat 3.0.6:P3.10:)fails on
mainwith:pinecone>=7.0.0(the floor declared inproviders/pinecone/pyproject.toml) removedproject_idfrom thePinecone()constructor and now does strict kwarg validation, soeven
project_id=Noneraises. The provider'sPineconeHookwas stillunconditionally passing the kwarg, which broke
providers/pinecone/tests/unit/pinecone/hooks/test_pinecone.py::TestPineconeHook::test_upsertproviders/pinecone/tests/unit/pinecone/hooks/test_pinecone.py::TestPineconeHook::test_debug_curl_settingThis PR drops the kwarg from the
Pinecone(...)call, removes theunused local extras lookup, and removes the
project_idconnectionform field +
provider.yamlextra so new connections don't expose afield that has no effect on the SDK any more. Existing connections
keep the saved value untouched (it's now silently ignored).
Test plan
uv run --project providers/pinecone pytest providers/pinecone/tests/unit/pinecone/hooks/test_pinecone.py -xvs— 17 / 17 pass.Compat 3.0.6:P3.10job goes green on this PR.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines