[v3-2-test] Fix ArgNotSet repr to use stable string instead of memory address (#65222)#66897
Merged
Conversation
…5222) * Add tests for ArgNotSet serialization and repr/str behavior * Add serialize, __repr__, __str__ to ArgNotSet for deterministic serialization * Flip ArgNotSet repr/str test to expect sentinel string and use top-level imports * Delegate ArgNotSet __repr__/__str__ to serialize() for polymorphic sentinel strings --------- Co-authored-by: taeyong <taeyong4.kim@navercorp.com> (cherry picked from commit e0587fd)
vatsrahul1001
force-pushed
the
backport-322-65222
branch
from
15f14d2 to
92ccfa5
Compare
vatsrahul1001
added a commit
that referenced
this pull request
May 20, 2026
…5222) (#66897) * Add tests for ArgNotSet serialization and repr/str behavior * Add serialize, __repr__, __str__ to ArgNotSet for deterministic serialization * Flip ArgNotSet repr/str test to expect sentinel string and use top-level imports * Delegate ArgNotSet __repr__/__str__ to serialize() for polymorphic sentinel strings --------- (cherry picked from commit e0587fd) Co-authored-by: necmo <necmoyuri@gmail.com> Co-authored-by: taeyong <taeyong4.kim@navercorp.com>
vatsrahul1001
added a commit
that referenced
this pull request
May 20, 2026
…5222) (#66897) * Add tests for ArgNotSet serialization and repr/str behavior * Add serialize, __repr__, __str__ to ArgNotSet for deterministic serialization * Flip ArgNotSet repr/str test to expect sentinel string and use top-level imports * Delegate ArgNotSet __repr__/__str__ to serialize() for polymorphic sentinel strings --------- (cherry picked from commit e0587fd) Co-authored-by: necmo <necmoyuri@gmail.com> Co-authored-by: taeyong <taeyong4.kim@navercorp.com>
vatsrahul1001
added a commit
that referenced
this pull request
May 21, 2026
…5222) (#66897) * Add tests for ArgNotSet serialization and repr/str behavior * Add serialize, __repr__, __str__ to ArgNotSet for deterministic serialization * Flip ArgNotSet repr/str test to expect sentinel string and use top-level imports * Delegate ArgNotSet __repr__/__str__ to serialize() for polymorphic sentinel strings --------- (cherry picked from commit e0587fd) Co-authored-by: necmo <necmoyuri@gmail.com> Co-authored-by: taeyong <taeyong4.kim@navercorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #65222
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines