Skip to content

Include dataset_id, table_id, poll_interval in BigQueryIntervalCheckTrigger serialization#66990

Closed
abhid-007 wants to merge 1 commit into
apache:mainfrom
abhid-007:fix/bigquery-interval-check-trigger-serialize
Closed

Include dataset_id, table_id, poll_interval in BigQueryIntervalCheckTrigger serialization#66990
abhid-007 wants to merge 1 commit into
apache:mainfrom
abhid-007:fix/bigquery-interval-check-trigger-serialize

Conversation

@abhid-007
Copy link
Copy Markdown

@abhid-007 abhid-007 commented May 15, 2026

BigQueryIntervalCheckTrigger.__init__ accepts dataset_id, table_id, and poll_interval and stores them via the parent BigQueryInsertJobTrigger.__init__, but serialize() omitted all three. After a triggerer restart the trigger was reinstantiated with defaults (dataset_id=None, table_id=None, poll_interval=4.0), silently changing polling cadence and dropping the templated table identity for any task that customised them.

This PR adds the three fields to the serialize() payload so the trigger round-trips through serialize() -> BigQueryIntervalCheckTrigger(**kwargs) cleanly. The existing serialization test gains the three new keys, and a round-trip test mirrors the pattern used by the sibling fixes in #66965 / #66966 / #66968.

This is the last of the five triggers called out in #66961; the static check that flags this class of bug is being introduced in #66960.

related: #66961
related: #66960


Was generative AI tooling used to co-author this PR?
  • Yes

…rigger serialization

`BigQueryIntervalCheckTrigger.__init__` accepts `dataset_id`, `table_id`,
and `poll_interval` and stores them via the parent class, but `serialize()`
omitted all three. After a triggerer restart the trigger was reinstantiated
with defaults (`dataset_id=None`, `table_id=None`, `poll_interval=4.0`),
silently changing the polling cadence and dropping the templated table
identity for any task that customised them.

Add the three fields to `serialize()` so the trigger round-trips through
`serialize()` -> `BigQueryIntervalCheckTrigger(**kwargs)` cleanly. Extend
the existing serialization test with the new keys and add a round-trip
test that mirrors the pattern used by the sibling fixes in apache#66965 /
apache#66966 / apache#66968.

related: apache#66961
@abhid-007 abhid-007 requested a review from shahar1 as a code owner May 15, 2026 10:53
@boring-cyborg boring-cyborg Bot added area:providers provider:google Google (including GCP) related issues labels May 15, 2026
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented May 15, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@abhid-007 abhid-007 marked this pull request as draft May 15, 2026 11:02
@shahar1
Copy link
Copy Markdown
Contributor

shahar1 commented May 17, 2026

Already merged here: #67053

@shahar1 shahar1 closed this May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants