Clarify logging_config_class and deprecate ES/OS implicit REMOTE_TASK_LOG registration#66994
Closed
jason810496 wants to merge 7 commits into
Closed
Conversation
…nd Opensearch task handlers
The warning previously fired inside ``discover_remote_log_handler`` during ``load_logging_config``, before ``dictConfig`` had constructed handlers. That misfired for the deprecated self-registration path in the Elasticsearch and OpenSearch task handlers, which populate ``_ActiveLoggingConfig.remote_task_log`` from inside ``__init__``. Drop the ``remote_logging_enabled`` parameter from ``discover_remote_log_handler`` and emit the warning from ``configure_logging`` after ``dictConfig`` runs, so the check sees the final state. Extract the duplicated test fixture into provider ``conftest.py`` files and switch the deprecation warnings to ``stacklevel=1`` so module-based deprecation filters still match.
jason810496
force-pushed
the
refactor/logging/clarify-logging-config-class
branch
from
517e225 to
ef217fc
Compare
jason810496
commented
May 16, 2026
| Changelog | ||
| --------- | ||
|
|
||
| ``ElasticsearchTaskHandler`` no longer silently registers itself as the remote |
Member
Author
There was a problem hiding this comment.
Not sure do I need to update the Changelog myself at this stage?
jason810496
requested review from
amoghrajesh,
ashb,
kaxil and
potiuk
as code owners
1 task
Contributor
|
Is it possible to split it to two PRs: core and providers? |
Member
Author
Sure, then I will separate them into core, ES and OS. I will raise PR soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
[logging] logging_config_classis documented as a "Logging class" but actually resolves to alogging.config.dictConfigdict, and theREMOTE_TASK_LOG/DEFAULT_REMOTE_CONN_IDside channel that powers remote log read-back was undocumented.So custom configs silently lost UI log read-back, and
ElasticsearchTaskHandler/OpensearchTaskHandlerpapered over it by self-registering from inside__init__.How
logging_config_class(dict, not class) and theREMOTE_TASK_LOG/DEFAULT_REMOTE_CONN_IDmodule-level attributes in the config option help,advanced-logging-configuration.rst, anddiscover_remote_log_handlerdocstring.AirflowProviderDeprecationWarning(stacklevel=1so module-based filters match throughdictConfig) and update the OpenSearch logging guide to setREMOTE_TASK_LOGat module scope.REMOTE_TASK_LOGwhileremote_loggingis on".Was generative AI tooling used to co-author this PR?