Decouple remote logging config from core#67056
Open
jason810496 wants to merge 7 commits into
Open
Conversation
jscheffl
reviewed
May 18, 2026
jscheffl
reviewed
May 18, 2026
jscheffl
reviewed
May 18, 2026
Contributor
jscheffl
left a comment
There was a problem hiding this comment.
Looks clean and good to me - except some small comments. Another pair of eyes would be good prior merge.
Fix type annotation
…config Decouple importing the [logging] logging_config_class dict from remote-handler resolution so each can run independently. The deprecated load_logging_config wrapper delegates to both and keeps the old return shape. Wire the lazy remote-handler load through the shared resolve_remote_task_log factory.
aa513bb to
37939dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logging_config_classand deprecate ES/OS implicitREMOTE_TASK_LOGregistration #66994Why
Decouple remote logging config from hardcoded
airflow-core/src/airflow/config_templates/airflow_local_settings.pyby introducing newremote-loggingfield forProvidersManager. Add sharedresolve_remote_task_logit, so core and the Task SDKshare one implementation of the precedence rule.
What
Single shared resolver
resolve_remote_task_logwith an explicit three-tier precedence:[logging] logging_config_classmodule exportingREMOTE_TASK_LOG/DEFAULT_REMOTE_CONN_ID.[logging] remote_base_log_folder,instantiated via the provider class's
from_config()classmethod.airflow.config_templates.airflow_local_settings(transitional).airflow.logging_config.load_logging_configis deprecated and split into_get_logging_config()(logging dict)_load_logging_config()(remote handler, lazy)configure_loggingno longer eagerly resolves the remote handler.Next step to deprecate hardcoded
airflow_local_settings.pyairflow_local_settings.pyasfrom_configmethod for each current supportedRemoteIO.RemoteIO.from_configis added.Was generative AI tooling used to co-author this PR?