[v3-2-test] Prefer gh auth over GitHub tokens for Breeze (#66255)#67078
Merged
Conversation
* Breeze: Prefer gh auth over GitHub tokens * Respect dry run functionality * Add Breeze GitHub helper edge-case tests * Clarify Breeze GitHub token precedence * Simplify release management GitHub token resolution * Clarify GITHUB_TOKEN console print (cherry picked from commit 7fef6c1)
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl and
vatsrahul1001
as code owners
1 task
vatsrahul1001
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #66255 to
v3-2-test.Brings in
run_gh_command/retrieve_github_tokenhelpers so Breeze prefers a user's storedgh auth logincredential over ambientGH_TOKEN/GITHUB_TOKENenv vars (with a retry against env tokens when the clean-env attempt fails).Also fixes a pre-existing latent break on
v3-2-test: the earlier backport #66776 referencedrun_gh_commandindev/breeze/src/airflow_breeze/commands/workflow_commands.pybut its prerequisite (this PR) had never been cherry-picked, leavingmypy-devfailing onv3-2-test. With this backport, the import resolves and mypy is green again.Conflicts during cherry-pick:
dev/breeze/src/airflow_breeze/utils/github.py— kept both the existingdataclass, fieldimport (still used byPRAssessment/Violation) and the newMapping, Sequenceimport introduced by Prefer gh auth over GitHub tokens for Breeze #66255.dev/breeze/src/airflow_breeze/commands/release_management_commands.py— left the airflow-ctl changelog block (_get_airflowctl_prs,generate_airflowctl_changelog, etc.) out, since that feature isn't onv3-2-testand Prefer gh auth over GitHub tokens for Breeze #66255 doesn't introduce it. Applied theretrieve_github_token(github_token) or ""line ingenerate_issue_content.dev/breeze/doc/images/output_*.{svg,txt}— regenerated viabreeze setup regenerate-command-images --forceso they reflect v3-2-test's actual command set (not main's).Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines