[v3-2-test] Updates our docker commands to use breeze prefix (#66368)#67079
Merged
Conversation
* Updates our docker commands to use breeze prefix Updates our docker commands which are called from breeze to have a breeze prefix, this helps by allowing breeze down to use prefix matching to cleanup. * Updates some of the missed container names * Undo removed comment * Fixes breeze cleanup ut and e2e tests Updates the UTs to only cleanup breeze prefix, updates e2e tests to create container with breeze prefix in the name * Remove merge conflict Refactor import of tomllib for Python version compatibility. * remove merge conflict * fixes test_bring_all_compose_projects_down_filters_unknown_by_default * Lint fixes (cherry picked from commit bca6a65)
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
kaxil and
vatsrahul1001
as code owners
boring-cyborg
Bot
added
area:dev-tools
area:docker-tests
area:production-image
vatsrahul1001
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #66368 to
v3-2-test.Prefixes Breeze-managed docker compose project names with
breeze-(e.g.breeze-quick-start,breeze-task-sdk-test,breeze-airflowctl-test,breeze-e2e-test) sobreeze downcan use prefix-matching to discover and clean up every Breeze-owned compose project in one shot. Also fixes the matching test and e2e/integration test container names, and thetest_bring_all_compose_projects_down_filters_unknown_by_defaulttest.Builds on #67078 ([v3-2-test] backport of #66255), which is already merged.
Conflicts during cherry-pick: only in the auto-generated breeze help artifacts (
dev/breeze/doc/images/output_*.{svg,txt}) — regenerated viabreeze setup regenerate-command-images --forceso they reflect v3-2-test's actual command set, not main's.All 50 breeze unit tests for the changed code (
tests/test_docker_command_utils.py,tests/test_github_utils.py) pass locally.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines