Fix "Trigger again with this config" ignoring param changes made in the UI#67253
Open
shashbha14 wants to merge 2 commits into
Open
Fix "Trigger again with this config" ignoring param changes made in the UI#67253shashbha14 wants to merge 2 commits into
shashbha14 wants to merge 2 commits into
Conversation
bbovenzi
requested changes
May 20, 2026
added 2 commits
May 21, 2026 17:03
584b564 to
13c28ef
Compare
bbovenzi
requested changes
May 22, 2026
Comment on lines
91
to
92
| }, | ||
| }); |
Contributor
There was a problem hiding this comment.
const { control, handleSubmit, watch } = useForm<DagRunTriggerParams>({
defaultValues,
values: { ...defaultValues, conf },
resetOptions: { keepDirtyValues: true },
});
Needing two useEffects shows us that there is a problem at the core of how we're handling this. Let's update our use of react-hook-form and then use just one useEffect to handle trigger again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67243
When using "Trigger again with this config", any changes made to params in the trigger form were ignored and the original conf from the previous run was submitted instead.
The useEffect that syncs the param store's conf back into the form field had a
!prefillConfigguard, which blocked it from running when "Trigger again" was used. So editing a param via the UI updated the store but the form field stayed on the original value.Removed the guard so the form always stays in sync with the store, and removed prefillConfig from the dependency array since it is no longer used inside that effect.