Skip to content

Fix "Trigger again with this config" ignoring param changes made in the UI #67253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shashbha14 wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Fix "Trigger again with this config" ignoring param changes made in the UI #67253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc6e79b
Fix Trigger again with config not applying modified params
May 20, 2026
13c28ef
Address review: use hasAppliedPrefill flag to respect prefill while s…
May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions airflow-core/src/airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ const TriggerDAGForm = ({
const { t: translate } = useTranslation(["common", "components"]);
const [errors, setErrors] = useState<{ conf?: string; date?: unknown }>({});
const [formError, setFormError] = useState(false);
const [hasAppliedPrefill, setHasAppliedPrefill] = useState(false);
const initialParamsDict = useDagParams(dagId, open);
const { conf, initialParamDict, setConf, setInitialParamDict } = useParamStore();
const [unpause, setUnpause] = useState(true);
const [hasAppliedPrefill, setHasAppliedPrefill] = useState(false);
const { mutate: togglePause } = useTogglePause({ dagId });

const { control, handleSubmit, reset, watch } = useForm<DagRunTriggerParams>({
Expand Down Expand Up @@ -130,12 +130,12 @@ const TriggerDAGForm = ({
isPartitioned,
]);

// Automatically reset form when conf is fetched (only if no prefillConfig)
// Automatically reset form when conf is fetched
useEffect(() => {
if (conf && open && (!prefillConfig || hasAppliedPrefill)) {
reset((prevValues) => ({ ...prevValues, conf }));
}
}, [conf, hasAppliedPrefill, prefillConfig, open, reset]);
}, [conf, hasAppliedPrefill, open, prefillConfig, reset]);

const resetDateError = () => setErrors((prev) => ({ ...prev, date: undefined }));

Expand Down
Loading