Skip to content

Fix dags test DagRun start date#67365

Open
bobu-putheeckal wants to merge 1 commit into
apache:mainfrom
bobu-putheeckal:codex-airflow-66127-dags-test-start-date
Open

Fix dags test DagRun start date#67365
bobu-putheeckal wants to merge 1 commit into
apache:mainfrom
bobu-putheeckal:codex-airflow-66127-dags-test-start-date

Conversation

@bobu-putheeckal
Copy link
Copy Markdown

Fixes #66127

DAG.test() currently passes start_date=logical_date or run_after when creating the test DagRun. When airflow dags test is invoked with an old logical date, the DagRun start date is recorded as that logical date, which inflates the reported run duration.

This changes DAG.test() to use run_after as the DagRun start date while preserving the requested logical date, and adds a regression test for the CLI path.

Testing:

  • python3 -m py_compile airflow-core/tests/unit/cli/commands/test_dag_command.py task-sdk/src/airflow/sdk/definitions/dag.py
  • git diff --check
  • Targeted pytest could not be run locally because the system pytest is too old for Airflow's current tests_common plugin; full uv setup needs Java for jpype1/JDBC provider.

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented May 23, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

airflow dags test sets DagRun.start_date to logical_date causing incorrect run_duration

1 participant