Fix dags test DagRun start date#67365
Open
bobu-putheeckal wants to merge 1 commit into
Open
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66127
DAG.test()currently passesstart_date=logical_date or run_afterwhen creating the test DagRun. Whenairflow dags testis invoked with an old logical date, the DagRun start date is recorded as that logical date, which inflates the reported run duration.This changes
DAG.test()to userun_afteras the DagRun start date while preserving the requested logical date, and adds a regression test for the CLI path.Testing:
python3 -m py_compile airflow-core/tests/unit/cli/commands/test_dag_command.py task-sdk/src/airflow/sdk/definitions/dag.pygit diff --checktests_commonplugin; fulluvsetup needs Java forjpype1/JDBC provider.