Skip to content

Fix dags test DagRun start date #67365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobu-putheeckal wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −1
Open

Fix dags test DagRun start date #67365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions airflow-core/tests/unit/cli/commands/test_dag_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,6 +966,23 @@ def test_dag_test_with_custom_timetable(self, mock_get_or_create_dagrun):
dag_command.dag_test(cli_args)
assert "data_interval" in mock_get_or_create_dagrun.call_args.kwargs

@mock.patch("airflow.models.dagrun.get_or_create_dagrun")
def test_dag_test_uses_current_time_as_dagrun_start_date(
self, mock_get_or_create_dagrun, time_machine
):
run_started_at = timezone.make_aware(datetime(2026, 4, 29, 21, 4), timezone=timezone.utc)
time_machine.move_to(run_started_at, tick=False)

cli_args = self.parser.parse_args(
["dags", "test", "example_bash_operator", DEFAULT_DATE.isoformat()]
)

dag_command.dag_test(cli_args)

assert mock_get_or_create_dagrun.call_args.kwargs["logical_date"] == DEFAULT_DATE
assert mock_get_or_create_dagrun.call_args.kwargs["run_after"] == run_started_at
assert mock_get_or_create_dagrun.call_args.kwargs["start_date"] == run_started_at

@mock.patch("airflow.models.dagrun.get_or_create_dagrun")
def test_dag_with_parsing_context(
self, mock_get_or_create_dagrun, testing_dag_bundle, configure_testing_dag_bundle
Expand Down
2 changes: 1 addition & 1 deletion task-sdk/src/airflow/sdk/definitions/dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,7 +1357,7 @@ def test(

dr: DagRun = get_or_create_dagrun(
dag=scheduler_dag,
start_date=logical_date or run_after,
start_date=run_after,
logical_date=logical_date,
data_interval=data_interval,
run_after=run_after,
Expand Down