Fix rendered_map_index sort order for mapped task instances#67531
Closed
manipatnam wants to merge 1 commit into
Closed
Fix rendered_map_index sort order for mapped task instances#67531manipatnam wants to merge 1 commit into
manipatnam wants to merge 1 commit into
Conversation
Sorting mapped task instances by rendered_map_index was producing
lexicographic order ("0","1","10","11","2") instead of numeric order
(0,1,2,...,10,11), and caused a 500 error on cursor pagination when
a CASE expression was used in to_replace.
Map rendered_map_index to the integer map_index column via a string
alias in SortParam.to_replace. This routes ORDER BY through the
integer column, fixing both the sort order and cursor pagination.
Also adds secondary_sort parameter to SortParam as generic
infrastructure for appending tiebreaker columns to ORDER BY.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.