Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions airflow-core/src/airflow/api_fastapi/common/parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -543,12 +543,17 @@ class SortParam(BaseParam[list[str]]):
MAX_SORT_PARAMS = 10

def __init__(
self, allowed_attrs: list[str], model: Base, to_replace: dict[str, str | Column] | None = None
self,
allowed_attrs: list[str],
model: Base,
to_replace: dict[str, str | Column] | None = None,
secondary_sort: dict[str, Column] | None = None,
) -> None:
super().__init__()
self.allowed_attrs = allowed_attrs
self.model = model
self.to_replace = to_replace
self.secondary_sort: dict[str, Column] = secondary_sort or {}
self._cached_resolution: list[tuple[str, ColumnElement, bool]] | None = None

def set_value(self, value: list[str] | None) -> Self:
Expand Down Expand Up @@ -611,10 +616,13 @@ def to_orm(self, select: Select, *, reversed: bool = False) -> Select:
raise ValueError(f"Cannot set 'skip_none' to False on a {type(self)}")

resolved = self._resolve()
if reversed:
columns = [col.asc() if is_desc else col.desc() for _, col, is_desc in resolved]
else:
columns = [col.desc() if is_desc else col.asc() for _, col, is_desc in resolved]
columns = []
for attr_name, col, is_desc in resolved:
effective_desc = not is_desc if reversed else is_desc
columns.append(col.desc() if effective_desc else col.asc())
secondary = self.secondary_sort.get(attr_name)
if secondary is not None:
columns.append(secondary.desc() if effective_desc else secondary.asc())
return select.order_by(None).order_by(*columns)

def get_resolved_columns(self) -> list[tuple[str, ColumnElement, bool]]:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ def get_mapped_task_instances(
"logical_date": DagRun.logical_date,
"data_interval_start": DagRun.data_interval_start,
"data_interval_end": DagRun.data_interval_end,
"rendered_map_index": "map_index",
},
).dynamic_depends(default="map_index")
),
Expand Down Expand Up @@ -508,6 +509,7 @@ def get_task_instances(
"run_after": DagRun.run_after,
"data_interval_start": DagRun.data_interval_start,
"data_interval_end": DagRun.data_interval_end,
"rendered_map_index": "map_index",
},
).dynamic_depends(default="map_index")
),
Expand Down
Loading