UI: Revert @chakra-ui/react bump that broke modal dismissal#67646
Merged
pierrejeambrun merged 1 commit intoMay 28, 2026
Conversation
pierrejeambrun
force-pushed
the
test/revert-chakra-bump-66225
branch
from
b2adc29 to
91008c8
Compare
pierrejeambrun
changed the title
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
apache#66225 bumped ``@chakra-ui/react`` from 3.34 to 3.35, which pulled in ``@ark-ui/react`` 5.34.1 → 5.36.2. The Ark 5.36 release notes flag: > Dialog / Drawer: Avoid setting inline ``pointer-events`` when modal, > letting the dismissable layer manage it. Before 5.36 the lock was an inline style on the dialog DOM, so it disappeared on unmount. After 5.36 the dismissable layer owns it and only releases it on close-transition completion. Several Clear / Mark-as buttons in this codebase mount their dialog conditionally (``{open ? <Dialog/> : undefined}``), which yanks the component out before the transition fires — the ``pointer-events: none`` overlay is left on ``document`` and the page refuses every click (scroll still works) until refresh. Revert the bump on its own; add a section to ``CONTRIBUTING.md`` so the next contributor trying to bump knows to rewrite the conditional-mount sites first.
pierrejeambrun
force-pushed
the
test/revert-chakra-bump-66225
branch
from
91008c8 to
385a47d
Compare
bbovenzi
approved these changes
May 28, 2026
Member
Author
|
Mergin, unrelated CI failure (shell script pre-commit hook) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
Open a Clear or Mark-as-success/failed dialog on a Dag Run or task
instance, close it without confirming, and the page becomes
unresponsive — only scroll works. Only a hard refresh recovers.
Root cause
#66225 (May 5, 2026) bumped
@chakra-ui/react3.34.0 → 3.35.0,which pulled in
@ark-ui/react5.34.1 → 5.36.2. From the Ark5.36.0release notes (2026-04-10):That pattern was accidentally safe with the old Ark for ~14 months;
the bump is what flipped it from working to broken.
Follow-up
The conditional-mount pattern is the actual fragile part — rewriting
those sites to always-render the dialog (and gate any expensive
dry-run queries with
enabled: open) would let us pick up Chakra3.35+ safely.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines