Fix dialog unmounting and unpin @chakra-ui/react (#67647)#67648
Closed
prattik-wav wants to merge 1 commit into
Closed
Fix dialog unmounting and unpin @chakra-ui/react (#67647)#67648prattik-wav wants to merge 1 commit into
prattik-wav wants to merge 1 commit into
Conversation
PR apache#67646 capped @chakra-ui/react at ~3.34.0 due to a page-unresponsive bug triggered by @ark-ui/react >= 5.36. The bug occurred because dialogs were conditionally unmounted before the close transition could run, leaving a `pointer-events: none` lock permanently stuck on the document. This commit resolves the underlying mounting issue and restores the upgrade path by: - Replacing conditionally-mounted dialogs with always-rendered components in Clear and Mark-as actions, relying on `lazyMount` so close transitions execute cleanly. - Gating expensive dry-run queries inside the dialogs with `enabled: open` to prevent unnecessary network requests. - Wrapping the `onClose` handler to properly reset local form state (e.g., typed notes and selected options) when a dialog is dismissed. - Unpinning and bumping @chakra-ui/react to ^3.35.0 in the UI package. - Removing the related dependency caveats from CONTRIBUTING.md. Resolves: apache#67647
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Member
There was a problem hiding this comment.
Thanks for opening the PR.
As mentionned in the related issue, there are othe places to update.
Also this introduce a regression regarding #47071, more info in the related issue.
You also need to upgrade Chakra dep, to trigger the bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
capped @chakra-ui/react at ~3.34.0 due to a page-unresponsive bug triggered by @ark-ui/react >= 5.36. The bug occurred because dialogs were conditionally unmounted before the close transition could run, leaving a
pointer-events: nonelock permanently stuck on the document.This commit resolves the underlying mounting issue and restores the upgrade path by:
lazyMountso close transitions execute cleanly.enabled: opento prevent unnecessary network requests.onClosehandler to properly reset local form state (e.g., typed notes and selected options) when a dialog is dismissed.Resolves: #67647