Skip to content

Fix dialog unmounting and unpin @chakra-ui/react (#67647)#67648

Closed
prattik-wav wants to merge 1 commit into
apache:mainfrom
prattik-wav:fix/unpin-chakra
Closed

Fix dialog unmounting and unpin @chakra-ui/react (#67647)#67648
prattik-wav wants to merge 1 commit into
apache:mainfrom
prattik-wav:fix/unpin-chakra

Conversation

@prattik-wav
Copy link
Copy Markdown

@prattik-wav prattik-wav commented May 28, 2026

capped @chakra-ui/react at ~3.34.0 due to a page-unresponsive bug triggered by @ark-ui/react >= 5.36. The bug occurred because dialogs were conditionally unmounted before the close transition could run, leaving a pointer-events: none lock permanently stuck on the document.

This commit resolves the underlying mounting issue and restores the upgrade path by:

  • Replacing conditionally-mounted dialogs with always-rendered components in Clear and Mark-as actions, relying on lazyMount so close transitions execute cleanly.
  • Gating expensive dry-run queries inside the dialogs with enabled: open to prevent unnecessary network requests.
  • Wrapping the onClose handler to properly reset local form state (e.g., typed notes and selected options) when a dialog is dismissed.
  • Unpinning and bumping @chakra-ui/react to ^3.35.0 in the UI package.
  • Removing the related dependency caveats from CONTRIBUTING.md.

Resolves: #67647

PR apache#67646 capped @chakra-ui/react at ~3.34.0 due to a page-unresponsive
bug triggered by @ark-ui/react >= 5.36. The bug occurred because dialogs
were conditionally unmounted before the close transition could run, leaving
a `pointer-events: none` lock permanently stuck on the document.

This commit resolves the underlying mounting issue and restores the
upgrade path by:
- Replacing conditionally-mounted dialogs with always-rendered components
  in Clear and Mark-as actions, relying on `lazyMount` so close
  transitions execute cleanly.
- Gating expensive dry-run queries inside the dialogs with `enabled: open`
  to prevent unnecessary network requests.
- Wrapping the `onClose` handler to properly reset local form state
  (e.g., typed notes and selected options) when a dialog is dismissed.
- Unpinning and bumping @chakra-ui/react to ^3.35.0 in the UI package.
- Removing the related dependency caveats from CONTRIBUTING.md.

Resolves: apache#67647
@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label May 28, 2026
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented May 28, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Copy Markdown
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR.

As mentionned in the related issue, there are othe places to update.

Also this introduce a regression regarding #47071, more info in the related issue.

You also need to upgrade Chakra dep, to trigger the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Unpin @chakra-ui/react (currently capped at ~3.34.0)

2 participants