AIP-103: Passing AssetStateAccessors through to BaseEventTrigger#67839
Draft
jroachgolf84 wants to merge 14 commits into
Draft
AIP-103: Passing AssetStateAccessors through to BaseEventTrigger#67839jroachgolf84 wants to merge 14 commits into
AssetStateAccessors through to BaseEventTrigger#67839jroachgolf84 wants to merge 14 commits into
Conversation
… context['asset_state']
Collaborator
Author
|
cc: @cmarteepants |
Collaborator
Author
|
cc: @vincbeck and @amoghrajesh, I closed the previous PR (#66595) after renaming the branch. We'll use this one instead. |
vincbeck
reviewed
Jun 1, 2026
Contributor
vincbeck
left a comment
There was a problem hiding this comment.
One nit but overall I like it
amoghrajesh
reviewed
Jun 2, 2026
Contributor
There was a problem hiding this comment.
The _handle_request should be handling this in here?
Collaborator
Author
There was a problem hiding this comment.
What do you mean?
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To ensure that classes inheriting from the
BaseEventTrigger(typically used for Asset watching) are "Asset-aware", the work done in AIP-103 has been wired into theBaseEventTriggerclass.#65103 drafted an approach that "flipped" the definition of the
AssetandAssetWatcher. However, for good reason, the approach was challenged. After conversation, the goal became to "pass" theAssetStateAccessorsthrough to theBaseEventTriggerwith some runtime magic.With this model, defining an
AssetandAssetWatcherremains the same as before.The two PR's below were closed in favor of this PR:
aip-93-scoping: AddingAssetWatcher.assetfunctionality #65103name/uriandAssetStateAccessorthrough toBaseEventTrigger#66595Testing
No unit tests have been written for this logic yet. However, testing has been performed E2E locally with
breeze. The trigger authored below is what was used for testing. When this ran, the Assetnameanduriwere output in the Triggerer logs.