-
Notifications
You must be signed in to change notification settings - Fork 17.2k
AIP-103: Passing AssetStateAccessors through to BaseEventTrigger
#67839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jroachgolf84
wants to merge
14
commits into
apache:main
Choose a base branch
from
jroachgolf84:feature/expose-asset-state-accessor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−0
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
05f7780
feature/aip-93-scoping: Passing Asset name/uri through to BaseEventTr…
jroachgolf84 8788b3d
feature/aip-93-scoping: Removing comment
jroachgolf84 f689676
Merge branch 'main' into feature/aip-93-scoping
jroachgolf84 e4c1db2
feature/aip-93-scoping: Moving from single to multi-Asset
jroachgolf84 2ee8213
Merge branch 'main' into feature/aip-93-scoping
jroachgolf84 ce953ef
feature/aip-93-scoping: Adding AssetStateAccessor
jroachgolf84 7be572d
feature/aip-93-scoping: Adding comment
jroachgolf84 b94483f
Merge branch 'main' into feature/aip-93-scoping
jroachgolf84 819795f
feature/aip-93-scoping: Adding comment to address potential change
jroachgolf84 e1f1953
Merge branch 'main' into feature/aip-93-scoping
jroachgolf84 788acb3
feature/aip-93-scoping: Updating asset_states -> asset_state to match…
jroachgolf84 b7cf568
feature/aip-93-scoping: Only passing asset_state through to BaseEvent…
jroachgolf84 3b01bbc
Merge branch 'main' into feature/expose-asset-state-accessor
jroachgolf84 ec3590c
feature/expore-asset-state-accessor: Implementing feedback
jroachgolf84 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
_handle_requestshould be handling this in here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean?