Skip to content

Propogate verify and botocore_config in redshift cluster triggers#67876

Merged
kaxil merged 3 commits into
apache:mainfrom
KarshVashi:fix/redshift-cluster-triggers-propagate-base-aws-params
Jun 2, 2026
Merged

Propogate verify and botocore_config in redshift cluster triggers#67876
kaxil merged 3 commits into
apache:mainfrom
KarshVashi:fix/redshift-cluster-triggers-propagate-base-aws-params

Conversation

@KarshVashi
Copy link
Copy Markdown
Contributor

@KarshVashi KarshVashi commented Jun 1, 2026

Five Redshift cluster triggers (RedshiftCreateClusterTrigger, RedshiftPauseClusterTrigger,
RedshiftCreateClusterSnapshotTrigger, RedshiftResumeClusterTrigger, RedshiftDeleteClusterTrigger)
did not forward verify, botocore_config, or even region_name to the hook, so deferrable
Redshift operators silently dropped custom SSL, botocore, and region settings when polling
AWS from the triggerer.

Follows the same pattern as the AWS Batch triggers migration (#67508) and the Lambda trigger
(providers/amazon/src/airflow/providers/amazon/aws/triggers/lambda_function.py).

What this changes:

  • Adds **kwargs passthrough in all five trigger __init__ methods so base-class params
    (verify, botocore_config) reach AwsBaseWaiterTrigger
  • Adds region_name as an explicit parameter (previously not forwarded to the hook at all)
  • Updates all five hook() methods to pass region_name, verify, and botocore_config
    to RedshiftHook
  • Updates operator defer sites in redshift_cluster.py to forward these params
  • Adds parametrized test coverage for serialization and hook propagation across all five triggers

RedshiftClusterTrigger is intentionally out of scope — it uses a custom polling loop with
BaseTrigger directly and a dynamic target_status rather than a single waiter, so migrating
it would require introducing custom waiters per state (noted by @dominikhei on #35278).

Part of #35278


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 4.7)

@KarshVashi KarshVashi requested a review from o-nikolas as a code owner June 1, 2026 22:41
@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues labels Jun 1, 2026
@kaxil kaxil merged commit 28e93c1 into apache:main Jun 2, 2026
180 of 181 checks passed
potiuk added a commit to potiuk/airflow that referenced this pull request Jun 2, 2026
Incremental-update pass for commits that landed on main after this wave was prepared:

- amazon: Propogate verify/botocore_config in redshift cluster triggers (apache#67876) → Features
  (mirrors the batch-triggers entry apache#67508).
- databricks: Lock in workflow depends_on parent-key behavior (apache#66681) → Bug Fixes.
- edge3: Fix Edge worker fork mode reporting supervisor failures as success (apache#67887) → Bug Fixes.
- google: Migrate Stackdriver logging config to RemoteLogIO pattern (apache#66513) → Misc.
potiuk added a commit that referenced this pull request Jun 3, 2026
* Prepare provider documentation 2026-06-02

* Address review feedback on provider changelogs

- amazon: move S3 transfer-operators fix (#67378, vincbeck) and EcsRunTaskOperator
  log-level fix (#67180, jscheffl) from Features to Bug Fixes; beautify the
  EksPodOperator entry (#65335).
- google: beautify the idle/auto-stop TTL entry (#65653) — drop conventional-commit prefix.
- openlineage: beautify the ProcessPoolExecutor self-heal entry (#67400).
- edge3: reword the 3.8.0 note — the provider still supports Airflow 3.0+, only the
  execute-callback feature (#67679) needs 3.3+ (jscheffl); move the Swagger API docs
  entry (#67390) to Doc-only; beautify the team_name clarification (#66718).
- apache/drill: move the flit.sdist housekeeping entry (#65861) to the excluded block
  to match the kafka convention (jscheffl).

* Make apache/drill 3.3.3 a doc-only release

The only non-excluded drill change in this wave was the flit.sdist housekeeping
entry, which jscheffl asked to exclude — leaving an empty changelog. Promote the
DAG-to-Dag wording change (#66153) into a Doc-only section so drill 3.3.3 ships as
a legitimate doc-only release instead of an empty one.

* Fold post-prep provider commits into changelogs

Incremental-update pass for commits that landed on main after this wave was prepared:

- amazon: Propogate verify/botocore_config in redshift cluster triggers (#67876) → Features
  (mirrors the batch-triggers entry #67508).
- databricks: Lock in workflow depends_on parent-key behavior (#66681) → Bug Fixes.
- edge3: Fix Edge worker fork mode reporting supervisor failures as success (#67887) → Bug Fixes.
- google: Migrate Stackdriver logging config to RemoteLogIO pattern (#66513) → Misc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants