Verify SSH host keys by default in the Git provider hook#69103
Merged
potiuk merged 1 commit intoJun 28, 2026
Conversation
The Git hook defaulted strict_host_key_checking to "no" and pointed the known_hosts file at /dev/null, so the SSH transport accepted any host key deploy without verification. Default to "accept-new" so a host key is trusted on first use and verified on every later connection. A deprecation warning announces the eventual move to "yes" so operators can configure known_hosts ahead of that change.
potiuk
approved these changes
Jun 28, 2026
Member
|
Nice! |
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jun 30, 2026
The Git hook defaulted strict_host_key_checking to "no" and pointed the known_hosts file at /dev/null, so the SSH transport accepted any host key deploy without verification. Default to "accept-new" so a host key is trusted on first use and verified on every later connection. A deprecation warning announces the eventual move to "yes" so operators can configure known_hosts ahead of that change.
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Git hook defaulted strict_host_key_checking to "no" and pointed the known_hosts file at /dev/null, so the SSH transport accepted any host key deploy without verification.
Default to "accept-new" so a host key is trusted on first use and verified on every later connection. A deprecation warning announces the eventual move to "yes" so operators can configure known_hosts ahead of that change.
Was generative AI tooling used to co-author this PR?
claude opus
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.