Skip to content

Verify SSH host keys by default in the Git provider hook#69103

Merged
potiuk merged 1 commit into
apache:mainfrom
astronomer:git-provider-host-key-verification
Jun 28, 2026
Merged

Verify SSH host keys by default in the Git provider hook#69103
potiuk merged 1 commit into
apache:mainfrom
astronomer:git-provider-host-key-verification

Conversation

@ephraimbuddy

Copy link
Copy Markdown
Contributor

The Git hook defaulted strict_host_key_checking to "no" and pointed the known_hosts file at /dev/null, so the SSH transport accepted any host key deploy without verification.

Default to "accept-new" so a host key is trusted on first use and verified on every later connection. A deprecation warning announces the eventual move to "yes" so operators can configure known_hosts ahead of that change.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    claude opus

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

The Git hook defaulted strict_host_key_checking to "no" and pointed the
known_hosts file at /dev/null, so the SSH transport accepted any host key
deploy without verification.

Default to "accept-new" so a host key is trusted on first use and verified
on every later connection. A deprecation warning announces the eventual
move to "yes" so operators can configure known_hosts ahead of that change.
@potiuk potiuk merged commit 5bb160e into apache:main Jun 28, 2026
145 checks passed
@potiuk

potiuk commented Jun 28, 2026

Copy link
Copy Markdown
Member

Nice!

karenbraganz pushed a commit to karenbraganz/airflow that referenced this pull request Jun 30, 2026
The Git hook defaulted strict_host_key_checking to "no" and pointed the
known_hosts file at /dev/null, so the SSH transport accepted any host key
deploy without verification.

Default to "accept-new" so a host key is trusted on first use and verified
on every later connection. A deprecation warning announces the eventual
move to "yes" so operators can configure known_hosts ahead of that change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants