Fix connection port field validation (#68382)#69130
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
|
Hi maintainers! 👋 This is my first contribution to Apache Airflow. Could someone please approve the CI workflow runs so the tests can execute? Also tagging @ashb since you commented on the original issue #68382 with guidance on the port validation approach. This PR implements validation (1-65535) across all entry points: core model, REST API, Task SDK, connection test model, and CLI — with a shared Thank you! 🙏 |
4412d09 to
cfa768b
Compare
There was a problem hiding this comment.
Thanks @Alwaysgaurav1 for the PR.
Unfortunately there is already #68777 opened for this and closer to being merged.
Closing in favor of it you can take a look at the reviews there a bunch also applies for yours.
This PR implements error propagation for variable write (
set) and delete (delete) operations inside the Task SDK. Previously, if the API server rejected these operations, the returnedErrorResponsewas ignored by the task runner, causing the task to report success despite a backend failure.closes: #68537
Was generative AI tooling used to co-author this PR?
Antigravity (Gemini 3.5 Flash)
Generated-by: Antigravity (Gemini 3.5 Flash) following the guidelines