Skip to content

Add input validation to ExecutorConfigType bind and result processors#69147

Closed
Atharva2012 wants to merge 1 commit into
apache:mainfrom
Atharva2012:add-input-validation
Closed

Add input validation to ExecutorConfigType bind and result processors#69147
Atharva2012 wants to merge 1 commit into
apache:mainfrom
Atharva2012:add-input-validation

Conversation

@Atharva2012

Copy link
Copy Markdown

Add input validation to ExecutorConfigType bind and result processors

ExecutorConfigType.bind_processor and result_processor did not validate their inputs. Passing a non-dict value would silently bypass the pod_override logic and either store unexpected data in the DB (on write) or return incorrect data (on read), with no helpful error message.
This PR adds:

  • A None early-return in both processors (NULL is valid for DB columns)

  • A TypeError with a descriptive message when the value is not a dict

  • Tests covering both valid and invalid inputs for both processors

closes: #69011

Was generative AI tooling used to co-author this PR?

  • Yes (please specify the tool below)
    Claude, to help word this PR and to navigate the codebase

@boring-cyborg

boring-cyborg Bot commented Jun 30, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Atharva2012 Atharva2012 force-pushed the add-input-validation branch from ebda38d to 280a263 Compare June 30, 2026 07:10
@Atharva2012 Atharva2012 force-pushed the add-input-validation branch from 280a263 to 991a9ca Compare June 30, 2026 17:52
@Atharva2012

Copy link
Copy Markdown
Author

This is my first contribution to airflow, have been using it or a while. Happy to address any feedback.
Thank you

@Atharva2012

Copy link
Copy Markdown
Author

Closing this as the related issue was marked not planned. Happy to revisit if members see any value in this direction.

@Atharva2012 Atharva2012 closed this Jul 1, 2026
@Atharva2012 Atharva2012 deleted the add-input-validation branch July 1, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing input validation could cause unexpected behavior with edge case inputs

1 participant