Add input validation to ExecutorConfigType bind and result processors#69147
Closed
Atharva2012 wants to merge 1 commit into
Closed
Add input validation to ExecutorConfigType bind and result processors#69147Atharva2012 wants to merge 1 commit into
Atharva2012 wants to merge 1 commit into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
ebda38d to
280a263
Compare
280a263 to
991a9ca
Compare
Author
|
This is my first contribution to airflow, have been using it or a while. Happy to address any feedback. |
Author
|
Closing this as the related issue was marked not planned. Happy to revisit if members see any value in this direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add input validation to ExecutorConfigType bind and result processors
ExecutorConfigType.bind_processor and result_processor did not validate their inputs. Passing a non-dict value would silently bypass the pod_override logic and either store unexpected data in the DB (on write) or return incorrect data (on read), with no helpful error message.
This PR adds:
A None early-return in both processors (NULL is valid for DB columns)
A TypeError with a descriptive message when the value is not a dict
Tests covering both valid and invalid inputs for both processors
closes: #69011
Was generative AI tooling used to co-author this PR?
Claude, to help word this PR and to navigate the codebase