Fix XCom slice endpoint returning wrong rows for crossed-bound slices#69205
Open
dhruv-techdev wants to merge 2 commits into
Open
Fix XCom slice endpoint returning wrong rows for crossed-bound slices#69205dhruv-techdev wants to merge 2 commits into
dhruv-techdev wants to merge 2 commits into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
A crossed-bound sequence slice (stop before start) evaluates to an empty list in Python, but the mapped-XCom slice endpoint translated it into a SQLAlchemy .slice() with a negative SQL LIMIT. On SQLite a negative LIMIT means "no limit", so rows were silently returned from the offset onward; on PostgreSQL/MySQL the negative LIMIT is rejected and the request fails. Return an empty result for crossed bounds so behaviour matches Python slicing on every backend.
7ecd72f to
29f39d0
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the mapped XCom sequence-slice API returning incorrect rows for crossed-bound slices, where stop comes before start.
In Python, crossed-bound slices such as items[5:2] return an empty list. However, the mapped-XCom slice endpoint translated this case into a SQLAlchemy .slice() call that could produce a negative SQL LIMIT.
This caused inconsistent behavior across databases:
SQLite treated the negative LIMIT as “no limit”, so it silently returned incorrect rows from the offset onward.
PostgreSQL/MySQL rejected the negative LIMIT, causing the request to fail.
This PR adds explicit handling for crossed-bound slices so the endpoint returns an empty result consistently across supported database backends, matching Python slicing behavior.
Tests were added/updated to cover the crossed-bound slice case.
closes: #69204