Fix async database engine setup for cockroachdb connection URIs#69260
Open
viragtripathi wants to merge 1 commit into
Open
Fix async database engine setup for cockroachdb connection URIs#69260viragtripathi wants to merge 1 commit into
viragtripathi wants to merge 1 commit into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
b034143 to
2bd2dba
Compare
1 task
ashb
requested changes
Jul 9, 2026
ashb
left a comment
Member
There was a problem hiding this comment.
Putting a temporary hold while we decide what we want to do -- see https://lists.apache.org/thread/qt7ohpwop8jgos1o8fszl4rv1ddkpz6v
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLAlchemy's registered cockroachdb dialect speaks the PostgreSQL wire protocol and uses asyncpg as its async driver. Airflow 3.x derives the async connection URI from the sync one via AIO_LIBS_MAPPING in settings.py; because cockroachdb is not in that map, startup fails with "The loaded 'psycopg2' is not async" unless the user hand-writes
sql_alchemy_conn_async. This adds the one mapping entry and a parametrized test for the derivation function, which previously had no direct coverage.
Discussed on the devlist:
https://lists.apache.org/thread/t6jo4th3sn23jmr34m6gcxzw4k8mo4pc
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code following the guidelines