Fixed KiotaRequestAdapterHook _is_http_client_closed method wrongly returning True when transport was not opened yet#69329
Merged
Conversation
…hat was never opened When the Azure credential transport had never been opened (_has_been_opened=False, session=None), _is_http_client_closed incorrectly returned True, causing get_async_conn to evict and rebuild a perfectly valid cached request adapter on every call. A never-opened transport is not closed; return False.
eladkal
approved these changes
Jul 3, 2026
potiuk
approved these changes
Jul 3, 2026
75 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
_is_http_client_closedincorrectly treating a never-opened transport as closedProblem
KiotaRequestAdapterHook._is_http_client_closedcontained a logic error:When the underlying Azure credential AioHttpTransport had never been opened (has_been_opened=False, session=None), the method returned True, signalling that the HTTP client was closed. As a result, get_async_conn discarded and rebuilt the cached RequestAdapter on every invocation even though it was perfectly healthy.
Fix
Return False for this branch — a transport that was never opened is not closed:
This is a follow-up PR on #69128.
Was generative AI tooling used to co-author this PR?
Claude Opus 4.6
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.