fix(execution-api): support connection IDs with slashes in get_connection route#69439
Open
Alwaysgaurav1 wants to merge 1 commit into
Open
fix(execution-api): support connection IDs with slashes in get_connection route#69439Alwaysgaurav1 wants to merge 1 commit into
Alwaysgaurav1 wants to merge 1 commit into
Conversation
Alwaysgaurav1
force-pushed
the
fix/57864-connections-path-slash
branch
from
1e878e8 to
20a4b15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Execution API endpoint
GET /execution/connections/{connection_id}uses a standard path parameter{connection_id}, which causes FastAPI to treat slashes in connection IDs as path separators. This means connection IDs containing slashes (e.g.my/slashed/conn) return a 404 Not Found instead of resolving correctly.This is inconsistent with the Variables endpoint which already uses
{variable_key:path}to support keys with slashes.This PR fixes the issue by changing the route definition from
/{connection_id}to/{connection_id:path}, allowing connection IDs with slashes to be properly resolved.A new unit test
test_connection_get_with_slashis added to verify that connections with slashed IDs can be fetched successfully.Closes: #57864