Skip to content

Fix partition label casing and Taiwanese Mandarin ranslations#69455

Merged
Lee-W merged 1 commit into
apache:mainfrom
astronomer:ui-i18n-partition-labels
Jul 6, 2026
Merged

Fix partition label casing and Taiwanese Mandarin ranslations#69455
Lee-W merged 1 commit into
apache:mainfrom
astronomer:ui-i18n-partition-labels

Conversation

@Lee-W

@Lee-W Lee-W commented Jul 6, 2026

Copy link
Copy Markdown
Member

Why

  • The English partition labels broke the Title Case convention every sibling Dag Run label follows — "Partition key" / "Mapped Partition key" used a lowercase key while neighbors like "Partition Date", "Queued At", "Run After" are all title-cased.
  • The Taiwanese Mandarin partition labels used 資產 (asset), wrongly implying these partitions are asset-only — cron and runtime-partitioned Dag Runs use the same generic labels, so 資源 is the correct prefix.
  • The Taiwanese Mandarin pending Dag runs strings dropped the {{count}} placeholder, so the button/modal text showed no number regardless of how many runs were pending.

What

  • en/common.json: "Partition key" → "Partition Key", "Mapped Partition key" → "Mapped Partition Key".
  • zh-TW/common.json: partitionDate 資產分區日期 → 資源分區日期; partitionKey 資產分區鍵 → 資源分區鍵.
  • zh-TW/common.json: pendingDagRun_one / pendingDagRun_other now prefix {{count}} 個 so the pending count renders.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Claude] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

The English partition key labels broke Title Case used by every sibling
Dag Run label, and the zh-TW translations wrongly prefixed 資產 (asset)
on cron/runtime-partitioned runs and dropped the {{count}} placeholder
from the pending Dag runs button/modal text.

@guan404ming guan404ming left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@henry3260 henry3260 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jason810496 jason810496 added this to the Airflow 3.3.1 milestone Jul 6, 2026
@Lee-W Lee-W merged commit 8aabd05 into apache:main Jul 6, 2026
85 checks passed
@Lee-W Lee-W deleted the ui-i18n-partition-labels branch July 6, 2026 12:57
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test PR Link

pierrejeambrun pushed a commit that referenced this pull request Jul 6, 2026
…ions (#69455) (#69470)

(cherry picked from commit 8aabd05)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Jul 7, 2026
…ions (#69455) (#69470)

(cherry picked from commit 8aabd05)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Jul 9, 2026
…ions (#69455) (#69470)

(cherry picked from commit 8aabd05)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:translations area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-3-test Backport to v3-3-test translation:default translation:zh-TW

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants