[v3-3-test] Archive worker-reported end date and rendered map index on task retry (#69248)#69458
Merged
Merged
Conversation
…n task retry (#69248) * Archive worker-reported end date and rendered map index on task retry Follow-up to #69235. The task_instance_history row for a retried try stamped archive-time utcnow() as end_date instead of the end date the worker reported, and missed the final rendered map index when the mid-run update was suppressed (e.g. template errors during failure handling). Snapshot both onto the TI before archiving, and let record_ti() respect a pre-set end_date so the audit trail reflects when the try actually ended. * Add test for record_ti fallback end_date stamping Cover the conditional branch where record_ti() archives a non-finished TI with end_date=None, verifying it gets stamped with utcnow() and duration is computed correctly. * Clarify record_ti comment covers pre-set duration too * Snapshot rendered_map_index in TIH when a retry explicitly clears it (cherry picked from commit 66b803d) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
1 task
jason810496
requested review from
XD-DENG,
amoghrajesh,
ashb and
kaxil
as code owners
jason810496
approved these changes
Jul 6, 2026
Lee-W
approved these changes
Jul 6, 2026
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
vatsrahul1001
pushed a commit
that referenced
this pull request
Jul 7, 2026
…n task retry (#69248) (#69458) * Archive worker-reported end date and rendered map index on task retry Follow-up to #69235. The task_instance_history row for a retried try stamped archive-time utcnow() as end_date instead of the end date the worker reported, and missed the final rendered map index when the mid-run update was suppressed (e.g. template errors during failure handling). Snapshot both onto the TI before archiving, and let record_ti() respect a pre-set end_date so the audit trail reflects when the try actually ended. * Add test for record_ti fallback end_date stamping Cover the conditional branch where record_ti() archives a non-finished TI with end_date=None, verifying it gets stamped with utcnow() and duration is computed correctly. * Clarify record_ti comment covers pre-set duration too * Snapshot rendered_map_index in TIH when a retry explicitly clears it (cherry picked from commit 66b803d) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Jul 9, 2026
…n task retry (#69248) (#69458) * Archive worker-reported end date and rendered map index on task retry Follow-up to #69235. The task_instance_history row for a retried try stamped archive-time utcnow() as end_date instead of the end date the worker reported, and missed the final rendered map index when the mid-run update was suppressed (e.g. template errors during failure handling). Snapshot both onto the TI before archiving, and let record_ti() respect a pre-set end_date so the audit trail reflects when the try actually ended. * Add test for record_ti fallback end_date stamping Cover the conditional branch where record_ti() archives a non-finished TI with end_date=None, verifying it gets stamped with utcnow() and duration is computed correctly. * Clarify record_ti comment covers pre-set duration too * Snapshot rendered_map_index in TIH when a retry explicitly clears it (cherry picked from commit 66b803d) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #69235. The task_instance_history row for a retried try
stamped archive-time utcnow() as end_date instead of the end date the
worker reported, and missed the final rendered map index when the
mid-run update was suppressed (e.g. template errors during failure
handling). Snapshot both onto the TI before archiving, and let
record_ti() respect a pre-set end_date so the audit trail reflects
when the try actually ended.
Cover the conditional branch where record_ti() archives a non-finished
TI with end_date=None, verifying it gets stamped with utcnow() and
duration is computed correctly.
Clarify record_ti comment covers pre-set duration too
Snapshot rendered_map_index in TIH when a retry explicitly clears it
(cherry picked from commit 66b803d)
Co-authored-by: Jason(Zhe-You) Liu 68415893+jason810496@users.noreply.github.com