Remove redundant session.commit() calls in FastAPI route handlers#69495
Merged
vincbeck merged 1 commit intoJul 7, 2026
Merged
Conversation
The database session in the FastAPI layer is injected via the SessionDep dependency, which automatically commits the transaction when a request completes successfully. Explicitly calling session.commit() inside the route handler is redundant and circumvents the dependency's intended transaction lifecycle management. This brings the route handlers in line with the codebase guideline that prohibits functions accepting a session parameter from calling commit. Closes: apache#69492
KushagraB424
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
kaxil,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
vincbeck
approved these changes
Jul 7, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
1 task
vincbeck
pushed a commit
that referenced
this pull request
Jul 8, 2026
…9495) (#69620) The database session in the FastAPI layer is injected via the SessionDep dependency, which automatically commits the transaction when a request completes successfully. Explicitly calling session.commit() inside the route handler is redundant and circumvents the dependency's intended transaction lifecycle management. This brings the route handlers in line with the codebase guideline that prohibits functions accepting a session parameter from calling commit. (cherry picked from commit 5e23c6a) Co-authored-by: Kushagra Gupta <kushagrab424@gmail.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Jul 9, 2026
…9495) (#69620) The database session in the FastAPI layer is injected via the SessionDep dependency, which automatically commits the transaction when a request completes successfully. Explicitly calling session.commit() inside the route handler is redundant and circumvents the dependency's intended transaction lifecycle management. This brings the route handlers in line with the codebase guideline that prohibits functions accepting a session parameter from calling commit. (cherry picked from commit 5e23c6a) Co-authored-by: Kushagra Gupta <kushagrab424@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The database session in the FastAPI layer is injected via the
SessionDepdependency, which is backed by thecreate_sessioncontext manager. This context manager automatically commits the transaction when a request completes successfully.Explicitly calling
session.commit()inside the route handler is redundant and circumvents the dependency's intended transaction lifecycle management. This brings these specific route handlers in line with the codebase guideline that prohibits functions accepting asessionparameter from callingcommit.Impacted Files
airflow/api_fastapi/execution_api/routes/xcoms.pyairflow/api_fastapi/execution_api/routes/hitl.pyairflow/api_fastapi/core_api/routes/public/hitl.pyairflow/api_fastapi/core_api/routes/public/backfills.pyCloses: #69492
Was generative AI tooling used to co-author this PR?
Generated-by: Antigravity following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.