Fix flaky test timeout test_end_drains_result_queue_to_avoid_join_deadlock on Python 3.14#69525
Closed
FrankYang0529 wants to merge 1 commit into
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
Member
|
Hey, I think it's been solved by #69538 instead. could you please check and confirm whehter my understanding is correct? Thanks! |
Member
Author
|
Yes, that is correct. Let me close my PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Python 3.14 changed the default multiprocessing start method on Linux from
forktoforkserver.With
fork, the child is "effectively identical to the parent process" and inherits the already-imported airflow modules. Withforkserverit is forked from a clean server process instead. The child must import the test module and related airflow import chain.From run 28801030578, both Postgres and Sqlite failed on the same test case
test_end_drains_result_queue_to_avoid_join_deadlockwith Python 3.14. Both took around 10 seconds to load modules.Other failed run:
How
Change the test's
execution_timeoutfrom 10s to 30s. Align it withtest_clean_stop_on_signalin the same file, which also spawns a subprocess.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.