Fix stale docs.sqlalchemy.org/en/14 pooling link in config.yml#69751
Open
singlaamitesh wants to merge 2 commits into
Open
Fix stale docs.sqlalchemy.org/en/14 pooling link in config.yml#69751singlaamitesh wants to merge 2 commits into
singlaamitesh wants to merge 2 commits into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
shahar1
previously requested changes
Jul 11, 2026
Contributor
There was a problem hiding this comment.
- Please fix the title, we don't use conventional commits.
- Please remove newsfragment.
- The original intention of the GitHub issue was to actually review the documentation to see that after upgrading to SQLA v2.0 everything still makes sense. Added it to the original issue, demoting from "fixes:" to "related:" + reordering the description.
How this was tested: airflow dags test...?
Removed the newsfragment and corrected the PR title/description per reviewer feedback, leaving only the config.yml en/14→en/20 link fix in the working tree for the orchestrator to commit.
Author
|
Thanks for the review!
Regarding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #69164
Fixed the stale docs.sqlalchemy.org/en/14 pooling link in config.yml to en/20, matching the SQLAlchemy 2.x version airflow-core now requires.
How this was tested:
airflow dags testWas generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Sonnet 5) following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.