Fix Azure Data Factory test broken by azure-mgmt-datafactory update#69785
Merged
Conversation
The test imported FactoryListResponse purely as an arbitrary non-empty placeholder for the mocked factories.list() iterator; test_connection never inspects the returned item. A recent azure-mgmt-datafactory release removed that model, so test collection failed in the uncapped-dependency Compat CI jobs on main. Use a neutral placeholder object so the test no longer depends on a specific SDK model.
boring-cyborg
Bot
added
area:providers
provider:microsoft-azure
gopidesupavan
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Azure Data Factory hook test imported
FactoryListResponsefromazure.mgmt.datafactory.modelsonly to use it as an arbitrary non-emptyplaceholder in a mocked
factories.list()iterator —test_connectionnever inspects the returned item. A recent
azure-mgmt-datafactoryrelease removed that model class, so test collection failed with
ImportError: cannot import name 'FactoryListResponse'in theuncapped-dependency Compat CI jobs, breaking the scheduled
mainbuild(and every PR that runs the full matrix, e.g. #69737).
Replace the placeholder with a neutral
object()so the test no longerdepends on a specific SDK model.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines