derive keycloak oauth redirect_uri from configured base url#69801
Merged
vincbeck merged 1 commit intoJul 13, 2026
Conversation
The login and login_callback routes built the OAuth redirect_uri from the request host, so behind --proxy-headers (where the API server trusts all X-Forwarded-Host) a request header could steer the callback URL that Keycloak sends the authorization code to. Use the configured [api] base_url instead, matching the logout and post-login redirects in the same file.
vincbeck
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keycloak login and login_callback routes built the OAuth redirect_uri with request.url_for, which Starlette derives from the request Host; with the API server started under --proxy-headers it trusts every X-Forwarded-Host, so a request header can steer the callback URL that Keycloak sends the authorization code to. This derives the redirect_uri from the configured [api] base_url instead, mirroring the logout and post-login redirects already in this file, and only falls back to the request URL when base_url is unset.
Was generative AI tooling used to co-author this PR?