[airflow-ctl/v0-1-test] Fix airflowctl JSON parsing for Dag run conf (#68985)#69837
Merged
bugraoz93 merged 1 commit intoJul 13, 2026
Merged
Conversation
…68985) * Fix airflowctl JSON parsing for Dag run conf airflowctl dags trigger --conf rejected JSON object strings because the generated parser validated them with raw dict, which cannot consume a JSON string. Parse JSON object CLI values into dictionaries before validation so conf values such as {"my-key": "my-value"} are accepted. closes: #67989 * Expand json_dict_type test coverage for airflowctl conf parsing Cover dict input early return, invalid JSON, and non-object JSON so all branches of the conf parser are exercised. --------- (cherry picked from commit a1cec52) Co-authored-by: Atakan Yenel <atakanyenel@gmail.com> Co-authored-by: Atakan Yenel <atakanyenel@microsoft.com>
1 task
bugraoz93
requested review from
bugraoz93,
dheerajturaga and
potiuk
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
airflowctl dags trigger --conf rejected JSON object strings because the
generated parser validated them with raw dict, which cannot consume a JSON
string. Parse JSON object CLI values into dictionaries before validation so
conf values such as {"my-key": "my-value"} are accepted.
closes: #67989
Cover dict input early return, invalid JSON, and non-object JSON so all
branches of the conf parser are exercised.
(cherry picked from commit a1cec52)
Co-authored-by: Atakan Yenel atakanyenel@gmail.com
Co-authored-by: Atakan Yenel atakanyenel@microsoft.com