Migrate Exasol provider to pyexasol 2.x#69987
Closed
Rishabjain999 wants to merge 1 commit into
Closed
Conversation
pyexasol 2.x ships a py.typed marker that exposed type mismatches in the Exasol hook. This removes the temporary <2 version cap and fixes all 8 mypy errors: - Rename the reused `conn` variable in get_conn() to `airflow_conn` / `exa_conn` to eliminate the type-narrowing conflict. - Add _validate_query_params() to narrow Iterable|Mapping|None down to dict|None, matching pyexasol 2.x's execute() and export_to_pandas() signatures. Raises TypeError with a clear message for non-dict input. - Narrow sql: str|list[str] to sql: str in get_records() and get_first(), matching what pyexasol actually accepts. - Bump pyexasol dependency from >=0.26.0,<2 to >=2.0.0,<3. closes: apache#69123
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Contributor
|
We already have several PRs for that issue. We don't need more. Please help review the previously submitted PRs |
Author
|
@eladkal any other pr or issue I can work on? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyexasol 2.x ships a
py.typedmarker that exposed 8 type mismatches inthe Exasol hook, causing CI to cap the dependency at
<2. This PR removesthe cap by fixing the hook to be compatible with pyexasol 2.x.
Changes:
connvariable inget_conn()toairflow_conn/exa_connto eliminate the mypy type-narrowing conflict.
_validate_query_params()static method to narrowIterable|Mapping|None→dict|None, matching pyexasol 2.x'sexecute()andexport_to_pandas()signatures. RaisesTypeErrorwith a clear message for non-dict input.
sql: str | list[str]→sql: stringet_records()andget_first(), matching what pyexasol actually accepts.pyexasoldependency from>=0.26.0,<2to>=2.0.0,<3.dictparameters (tuples were never valid).closes: #69123