Skip to content

Add optional AI agent rules to React plugin template - #69994

Merged
bbovenzi merged 3 commits into
apache:mainfrom
shaealh:shaealh/airflow-53748-ai-agent-rules
Jul 21, 2026
Merged

Add optional AI agent rules to React plugin template#69994
bbovenzi merged 3 commits into
apache:mainfrom
shaealh:shaealh/airflow-53748-ai-agent-rules

Conversation

@shaealh

@shaealh shaealh commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Ask whether AI agent coding rules should be included when bootstrapping a React plugin.
  • Add tool-agnostic rules covering Airflow plugin integration, React and TypeScript practices, and testing.
  • Document how to adapt the generated rules for Cursor, GitHub Copilot, and other tools.
  • Add tests for both opt-in and default opt-out behavior.

Testing

  • uv run --frozen --project scripts pytest scripts/tests/test_react_plugin_bootstrap.py -xvs
  • Airflow commit hooks passed, except lychee-docker, which was skipped because Docker was unavailable.
  • Manually verified both the opt-in and default opt-out bootstrap flows.

closes: #53748


Was generative AI tooling used to co-author this PR?
  • Yes (OpenAI Codex)

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, overall looking good!

Just a couple of nits before we can merge.

Comment thread dev/react-plugin-tools/react_plugin_template/ai-agent-rules/airflow-plugin.md Outdated
Comment thread dev/react-plugin-tools/react_plugin_template/ai-agent-rules/airflow-plugin.md Outdated
@pierrejeambrun pierrejeambrun added this to the Airflow 3.3.1 milestone Jul 20, 2026
@pierrejeambrun pierrejeambrun removed the ready for maintainer review Set after triaging when all criteria pass. label Jul 20, 2026
@potiuk

potiuk commented Jul 20, 2026

Copy link
Copy Markdown
Member

@shaealh — There are 2 unresolved review thread(s) on this PR from @pierrejeambrun. Could you either push a fix or reply in each thread explaining why the feedback doesn't apply? Once you believe the feedback is addressed, mark the thread as resolved so the reviewer isn't re-pinged needlessly. Thanks!


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@shaealh

shaealh commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

@pierrejeambrun thank you for reviewing, feedback addressed, let me know you can merge. Thanks

@bbovenzi
bbovenzi merged commit 723b06b into apache:main Jul 21, 2026
155 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test PR Link

@shaealh
shaealh deleted the shaealh/airflow-53748-ai-agent-rules branch July 21, 2026 23:40
pierrejeambrun pushed a commit that referenced this pull request Jul 23, 2026
) (#70193)

* Add optional AI agent rules to React plugin template

* Address React plugin AI rule feedback
(cherry picked from commit 723b06b)

Co-authored-by: Shae Alhusayni <shae.alh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AIP - 68 AI Rules for templated react projects

4 participants