[v3-3-test] Don't deactivate DAG bundles owned by other dag-processors (#69964)#70017
Merged
Conversation
#69964) `DagBundlesManager.sync_bundles_to_db()` marks every stored bundle that is not in the calling process's config as inactive. This assumes the caller sees the complete bundle configuration. When multiple dag-processors are each configured with a partial config (one bundle per processor, a natural way to shard parsing), each processor treats the other processors' bundles as "no longer found in config" and disables them. Processor A disables B's bundle, B disables A's, and they flip `dag_bundle.active` on every parse cycle -- the deployment never converges and continuously logs "DAG bundle ... is no longer found in config and has been disabled" for bundles that are actively configured elsewhere. Add a `deactivate_missing` flag (default `True`, preserving existing single-processor behavior) and have `DagFileProcessorManager.sync_bundles()` pass `deactivate_missing=False` when the processor was started with a bundle filter (`--bundle-name` / `bundle_names_to_parse`), i.e. when it only owns a subset of the bundles. closes: #69963 related: #69698 (cherry picked from commit 038ece6) Co-authored-by: Sebastián Ortega <sebastian.ortegatorres@datadoghq.com> Generated-by: Claude Code following the guidelines
1 task
potiuk
marked this pull request as ready for review
July 19, 2026 20:31
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DagBundlesManager.sync_bundles_to_db()marks every stored bundle that isnot in the calling process's config as inactive. This assumes the caller
sees the complete bundle configuration.
When multiple dag-processors are each configured with a partial config (one
bundle per processor, a natural way to shard parsing), each processor treats
the other processors' bundles as "no longer found in config" and disables
them. Processor A disables B's bundle, B disables A's, and they flip
dag_bundle.activeon every parse cycle -- the deployment never convergesand continuously logs "DAG bundle ... is no longer found in config and has
been disabled" for bundles that are actively configured elsewhere.
Add a
deactivate_missingflag (defaultTrue, preserving existingsingle-processor behavior) and have
DagFileProcessorManager.sync_bundles()pass
deactivate_missing=Falsewhen the processor was started with a bundlefilter (
--bundle-name/bundle_names_to_parse), i.e. when it only owns asubset of the bundles.
closes: #69963
related: #69698
(cherry picked from commit 038ece6)
Co-authored-by: Sebastián Ortega sebastian.ortegatorres@datadoghq.com
Generated-by: Claude Code following the guidelines