fix(providers/google): support sovereign console links - #70175
Open
auyua9 wants to merge 1 commit into
Open
Conversation
(cherry picked from commit 8ded654)
Contributor
|
Static checks are failing as PR title needs to be updated to resolve colon sign and conventional text. Please run prek locally successfully, before pushing your branch to Airflow github repo @auyua9 |
Author
|
I investigated the failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Completes the Trusted Partner Cloud console-link handling for two remaining user-visible URLs:
Both now use
GoogleBaseHook.get_high_value_cookie_domain()while preserving the defaultgoogle.comdomain.Tests
uv run --package apache-airflow-providers-google pytest providers/google/tests/unit/google/cloud/bundles/test_gcs.py -quv run --package apache-airflow-providers-google pytest providers/google/tests/unit/google/cloud/log/test_stackdriver_task_handler.py::TestStackdriverLoggingHandlerTask::test_should_return_valid_external_url -qruff checkon the four changed filesImportant
🛠️ Maintainer triage note for @auyua9 · by
@potiuk· 2026-07-28 16:22 UTCHelpful heads-up from the maintainers — please address before this PR can be reviewed:
The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.
See the Pull Request quality criteria for how to fix each item. There is no rush.
Note: your branch is 199 commits behind
main— please rebase and push again to get up-to-date CI results.Automated triage — may be imperfect; a maintainer takes the next look. We use this two-stage triage process so maintainers' limited time goes to the conversation with you.