Skip to content

fix(providers/google): support sovereign console links - #70175

Open
auyua9 wants to merge 1 commit into
apache:mainfrom
auyua9:fix/tpc-remaining-google-console-links-current
Open

fix(providers/google): support sovereign console links#70175
auyua9 wants to merge 1 commit into
apache:mainfrom
auyua9:fix/tpc-remaining-google-console-links-current

Conversation

@auyua9

@auyua9 auyua9 commented Jul 21, 2026

Copy link
Copy Markdown

What changed

Completes the Trusted Partner Cloud console-link handling for two remaining user-visible URLs:

  • Stackdriver task-log viewer links
  • GCS DAG bundle browser links

Both now use GoogleBaseHook.get_high_value_cookie_domain() while preserving the default google.com domain.

Tests

  • uv run --package apache-airflow-providers-google pytest providers/google/tests/unit/google/cloud/bundles/test_gcs.py -q
  • uv run --package apache-airflow-providers-google pytest providers/google/tests/unit/google/cloud/log/test_stackdriver_task_handler.py::TestStackdriverLoggingHandlerTask::test_should_return_valid_external_url -q
  • ruff check on the four changed files

Important

🛠️ Maintainer triage note for @auyua9 · by @potiuk · 2026-07-28 16:22 UTC

Helpful heads-up from the maintainers — please address before this PR can be reviewed:

  • Pre-commit / static checks. See docs.

The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.

See the Pull Request quality criteria for how to fix each item. There is no rush.

Note: your branch is 199 commits behind main — please rebase and push again to get up-to-date CI results.

Automated triage — may be imperfect; a maintainer takes the next look. We use this two-stage triage process so maintainers' limited time goes to the conversation with you.

@auyua9
auyua9 requested a review from shahar1 as a code owner July 21, 2026 09:47
@boring-cyborg boring-cyborg Bot added area:logging area:providers provider:google Google (including GCP) related issues labels Jul 21, 2026
@Srabasti

Copy link
Copy Markdown
Contributor

Static checks are failing as PR title needs to be updated to resolve colon sign and conventional text.

Please run prek locally successfully, before pushing your branch to Airflow github repo @auyua9

@auyua9 auyua9 changed the title fix(providers/google): support sovereign console links Support sovereign console links for Google provider Jul 23, 2026
@auyua9 auyua9 changed the title Support sovereign console links for Google provider fix(providers/google): support sovereign console links Jul 25, 2026
@auyua9

auyua9 commented Aug 3, 2026

Copy link
Copy Markdown
Author

I investigated the failing CI image checks / Static checks result on this head. The failure is in the upstream providers/common/ai/provider.yaml validation (toolsets/python-modules schema / AWSToolset registration), while this PR only changes the provider path and tests. There is no safe in-scope fix without expanding the PR into unrelated provider metadata. Please re-run after the upstream provider.yaml regression is corrected, or confirm the preferred upstream fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logging area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants