[v3-3-test] Route SQLAlchemyError through global exception handler (#69267) - #70236
Merged
Conversation
…69267) * Route SQLAlchemyError through global exception handler * Replace manual traceback with logging * Update airflow-core/src/airflow/api_fastapi/common/exceptions.py Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com> * Add test for ti_run and include traceback when expose_stacktrace=True * Add test for ti_run and include traceback when expose_stacktrace=True * fix referenced before assignment problems * Handle execution API database errors consistently * Handle execution API database errors consistently * Refactor duplicated database error handling into helper * fix code format * Trigger CI rerun * Move database error response handling into handler class --------- (cherry picked from commit 7c03dab) Co-authored-by: fat-catTW <124506982+fat-catTW@users.noreply.github.com> Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
1 task
pierrejeambrun
marked this pull request as ready for review
July 22, 2026 12:52
pierrejeambrun
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
kaxil,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
July 22, 2026 12:52
pierrejeambrun
approved these changes
Jul 22, 2026
jason810496
reviewed
Jul 22, 2026
Member
When it has no 'user impact' and it's a 'refactor' it's better to backport anyway to reduce the drift with 'main'. Otherwise the accumulation of such refactoring can bring a lot of conflicts in the future. And since v3-3-test branch is fresh, this will last for a while. Also this can also fix cryptic error messages (SQLAlchemy exception) for parts of the code where it was not handled/unexpected, so it can only help to backport. |
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
vatsrahul1001
added
the
type:misc/internal
vatsrahul1001
pushed a commit
that referenced
this pull request
Aug 5, 2026
…69267) (#70236) * Route SQLAlchemyError through global exception handler * Replace manual traceback with logging * Update airflow-core/src/airflow/api_fastapi/common/exceptions.py * Add test for ti_run and include traceback when expose_stacktrace=True * Add test for ti_run and include traceback when expose_stacktrace=True * fix referenced before assignment problems * Handle execution API database errors consistently * Handle execution API database errors consistently * Refactor duplicated database error handling into helper * fix code format * Trigger CI rerun * Move database error response handling into handler class --------- (cherry picked from commit 7c03dab) Co-authored-by: fat-catTW <124506982+fat-catTW@users.noreply.github.com> Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route SQLAlchemyError through global exception handler
Replace manual traceback with logging
Update airflow-core/src/airflow/api_fastapi/common/exceptions.py
Co-authored-by: Jason(Zhe-You) Liu 68415893+jason810496@users.noreply.github.com
Add test for ti_run and include traceback when expose_stacktrace=True
Add test for ti_run and include traceback when expose_stacktrace=True
fix referenced before assignment problems
Handle execution API database errors consistently
Handle execution API database errors consistently
Refactor duplicated database error handling into helper
fix code format
Trigger CI rerun
Move database error response handling into handler class
(cherry picked from commit 7c03dab)
Co-authored-by: fat-catTW 124506982+fat-catTW@users.noreply.github.com
Co-authored-by: Jason(Zhe-You) Liu 68415893+jason810496@users.noreply.github.com