Fix Trigger Again showing empty config for the selected run - #70248
Merged
pierrejeambrun merged 1 commit intoJul 23, 2026
Conversation
Re-triggering a Dag with the config of a selected run left the configuration empty ("{}") whenever the Dag had no declared params or its params had not loaded yet: the prefill only pushed the run's conf into the param store when params were present, so the sync effect overwrote the form back to the default empty config and the selected run's configuration was lost.
pierrejeambrun
marked this pull request as ready for review
July 22, 2026 15:54
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
July 22, 2026 15:54
Member
|
Does this also work if "arbitrary" json conf is provided? |
ashb
approved these changes
Jul 22, 2026
Member
Author
Yes, an arbitrary config is propagated via the 'trigger again with config' button. It wasn't clear in my previous video because it looks like the dag had params, but the dag had no conf and it was added manually when starting the previous run. Here is a better example Screen.Recording.2026-07-23.at.10.43.29.mov |
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
pierrejeambrun
added a commit
that referenced
this pull request
Jul 24, 2026
…un (#70248) (#70288) Re-triggering a Dag with the config of a selected run left the configuration empty ("{}") whenever the Dag had no declared params or its params had not loaded yet: the prefill only pushed the run's conf into the param store when params were present, so the sync effect overwrote the form back to the default empty config and the selected run's configuration was lost. (cherry picked from commit 58160be) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-triggering a Dag with the config of a selected run (the "Trigger DAG w/ config" / "Trigger Again with config" menu item) left the configuration empty — the JSON editor showed
{}and the selected run'sconfwas not carried over.The prefill only pushed the run's
confinto the param store when the Dag's declared params were already present. For Dags with no declared params (or before the params query resolved), that branch was skipped, so the param store kept its default empty config and the sync effect reset the form back to{}, dropping the run's configuration. The conf is now always propagated to the param store on prefill; seeding the initial params (for stable section ordering) still waits until they are available.Before / after (config carried over from the selected run):
Before
Screen.Recording.2026-07-22.at.17.56.03.mov
After
Screen.Recording.2026-07-22.at.17.55.13.mov
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines