[v3-3-test] Add partition date filters to Dag run API (#68682) - #70304
Merged
Conversation
* Add partition date support to Dag run API * Reject partition date filters on non-partitioned Dags in Dag run API Runs of a non-partitioned Dag never carry a partition_date, so filtering by partition_date_start/partition_date_end silently returned an empty list, which reads as "no runs in that window" rather than "this Dag has no partition dimension". Return 400 instead, mirroring how supplying a partition_key for a non-partitioned Dag is rejected. * Rename Dag run partition date filters to partition_date_gte/lte The other range filters on the list Dag runs endpoint use the _gte/_lte suffix convention (start_date_gte, logical_date_lte, ...), so the new partition date bounds should follow it too. Also clarify in the query parameter descriptions that the inclusive bounds cover the whole calendar day, and fold the partition-date branches into a single condition so the 400 paths and the filter path read in one place. (cherry picked from commit 8e6f28f) Co-authored-by: Henry Chen <henrychen@apache.org>
boring-cyborg
Bot
added
area:API
1 task
henry3260
approved these changes
Jul 23, 2026
henry3260
marked this pull request as ready for review
July 23, 2026 14:58
henry3260
requested review from
XD-DENG,
ashb,
bbovenzi,
bugraoz93,
choo121600,
ephraimbuddy,
guan404ming,
jason810496,
pierrejeambrun,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
July 23, 2026 14:58
bbovenzi
approved these changes
Jul 23, 2026
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
vatsrahul1001
added
the
type:misc/internal
vatsrahul1001
pushed a commit
that referenced
this pull request
Aug 5, 2026
* Add partition date support to Dag run API * Reject partition date filters on non-partitioned Dags in Dag run API Runs of a non-partitioned Dag never carry a partition_date, so filtering by partition_date_start/partition_date_end silently returned an empty list, which reads as "no runs in that window" rather than "this Dag has no partition dimension". Return 400 instead, mirroring how supplying a partition_key for a non-partitioned Dag is rejected. * Rename Dag run partition date filters to partition_date_gte/lte The other range filters on the list Dag runs endpoint use the _gte/_lte suffix convention (start_date_gte, logical_date_lte, ...), so the new partition date bounds should follow it too. Also clarify in the query parameter descriptions that the inclusive bounds cover the whole calendar day, and fold the partition-date branches into a single condition so the 400 paths and the filter path read in one place. (cherry picked from commit 8e6f28f) Co-authored-by: Henry Chen <henrychen@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add partition date support to Dag run API
Reject partition date filters on non-partitioned Dags in Dag run API
Runs of a non-partitioned Dag never carry a partition_date, so filtering
by partition_date_start/partition_date_end silently returned an empty
list, which reads as "no runs in that window" rather than "this Dag has
no partition dimension". Return 400 instead, mirroring how supplying a
partition_key for a non-partitioned Dag is rejected.
The other range filters on the list Dag runs endpoint use the _gte/_lte
suffix convention (start_date_gte, logical_date_lte, ...), so the new
partition date bounds should follow it too. Also clarify in the query
parameter descriptions that the inclusive bounds cover the whole
calendar day, and fold the partition-date branches into a single
condition so the 400 paths and the filter path read in one place.
(cherry picked from commit 8e6f28f)
Co-authored-by: Henry Chen henrychen@apache.org