Drop unused post_submit_commands copy from SparkSubmitOperator init - #70323
Merged
shahar1 merged 1 commit intoJul 24, 2026
Merged
Conversation
post_submit_commands is a template field, so it is rendered after __init__ runs. The constructor kept a second, private list copy (self._post_submit_commands) built from the un-rendered value, but nothing reads it: the operator forwards the rendered self.post_submit_commands to SparkSubmitHook, which builds its own list. Removing the dead copy stops the constructor reading the template field and lets its validate-operators-init exemption go. related: apache#70296 Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
July 23, 2026 19:16
1fanwang
marked this pull request as draft
July 24, 2026 05:47
1fanwang
marked this pull request as ready for review
July 24, 2026 06:23
Contributor
Backport failed to create: v3-3-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker dca1d97 v3-3-testThis should apply the commit to the v3-3-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
post_submit_commandsis a template field, so it is rendered after__init__runs. The constructor also kept a privateself._post_submit_commands = list(post_submit_commands) if post_submit_commands else [], built from the un-rendered value. Nothing reads that copy: the operator forwards the renderedself.post_submit_commandstoSparkSubmitHook, which builds its own list and runs the commands. Removing it stops the constructor reading the template field and clears itsvalidate-operators-initexemption.related: #70296
Testing Done
validate_operators_init.pyon the operator, before (with the exemption removed):After removing the line, the validator exits 0.
test_spark_submit.py(operator suite): 69 passed. The removed attribute had no readers, so behaviour is unchanged.Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot CLI following the guidelines