Skip to content

Move template-field validation out of init for Amazon DataSync operator - #70324

Merged
shahar1 merged 2 commits into
apache:mainfrom
Avcu:template_fields
Jul 24, 2026
Merged

Move template-field validation out of init for Amazon DataSync operator#70324
shahar1 merged 2 commits into
apache:mainfrom
Avcu:template_fields

Conversation

@Avcu

@Avcu Avcu commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Template fields are rendered only after operators' constructor runs. Therefore, I moved the field validation logic out of __init__ for Amazon DataSync operator. I also updated the unit tests accordingly and run them locally.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • No

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@justinpakzad

Copy link
Copy Markdown
Contributor

Just an fyi - I think you will also need to delete the class path in the validate_operators_init_exemptions.txt file.

@Avcu

Avcu commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Just an fyi - I think you will also need to delete the class path in the validate_operators_init_exemptions.txt file.

Thank you @justinpakzad, I have updated my PR.

@Avcu
Avcu force-pushed the template_fields branch from 39fa63c to 5e325d1 Compare July 24, 2026 03:16

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@shahar1
shahar1 merged commit b25d191 into apache:main Jul 24, 2026
83 checks passed
@Avcu
Avcu deleted the template_fields branch July 24, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants