Strip GlueDataQualityOperator ruleset after rendering - #70331
Merged
Conversation
ruleset is a template field, so it is rendered after __init__ runs. The
constructor did self.ruleset = ruleset.strip(), which strips the un-rendered
value. A templated ruleset that renders with surrounding whitespace is therefore
never stripped, and validate_inputs() rejects it because the rendered value no
longer ends with ']':
AttributeError: RuleSet must starts with Rules = [ and ends with ]
Store ruleset verbatim in the constructor and strip the rendered value at the
start of execute(), before validation.
related: apache#70296
Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
o-nikolas and
potiuk
as code owners
July 23, 2026 21:09
boring-cyborg
Bot
added
area:dev-tools
area:providers
backport-to-v3-3-test
1fanwang
marked this pull request as draft
July 24, 2026 05:47
Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
marked this pull request as ready for review
July 24, 2026 06:23
shahar1
reviewed
Jul 24, 2026
shahar1
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rulesetis a template field, so it is rendered after__init__runs. The constructor didself.ruleset = ruleset.strip(), which strips the un-rendered value. A templatedrulesetthat renders with surrounding whitespace is therefore never stripped, andvalidate_inputs()rejects it because the rendered value no longer ends with]:Store
rulesetverbatim in the constructor and strip the rendered value at the start ofexecute(), before validation.related: #70296
Testing Done
Operator-level repro (real Dag, real render, real
executewith a mocked Glue conn). Before the fix, a templated ruleset rendering to' Rules = [...] 'reachesvalidate_inputs()unstripped and raises:After the fix,
execute()strips first and the API receives the clean'Rules = [...]'. The newtest_execute_strips_rendered_rulesetdrives that render→execute path; it fails on the pre-fix source and passes after.TestGlueDataQualityOperator: 11 passed.Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot CLI following the guidelines