Skip to content

Remove noqa:S101 from production code#70378

Merged
shahar1 merged 1 commit into
apache:mainfrom
astronomer:remove-s101-noqa
Jul 24, 2026
Merged

Remove noqa:S101 from production code#70378
shahar1 merged 1 commit into
apache:mainfrom
astronomer:remove-s101-noqa

Conversation

@Lee-W

@Lee-W Lee-W commented Jul 24, 2026

Copy link
Copy Markdown
Member

Why

during reviewing #70338, I found out we introduced assert into production code. according to https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#don-t-use-asserts-outside-tests, we do not want this.

What

use if TYPE_CHECKING as what we did elsewhere


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@shahar1 shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@shahar1
shahar1 merged commit 2f7f70b into apache:main Jul 24, 2026
157 of 158 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants